You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2023/08/29 22:52:11 UTC
[GitHub] [accumulo-website] ctubbsii opened a new pull request, #400: Use bootstrap styling for dataTables
ctubbsii opened a new pull request, #400:
URL: https://github.com/apache/accumulo-website/pull/400
* Use Bootstrap 3 instead of dataTables default styling, so the tables can fit the rest of the site's theme by default
* This will need to be switched to Bootstrap 5 versions when Bootstrap is updated
Follow up from #396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] DomGarguilo merged pull request #400: Use bootstrap styling for dataTables
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #400:
URL: https://github.com/apache/accumulo-website/pull/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on pull request #400: Use bootstrap styling for dataTables
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #400:
URL: https://github.com/apache/accumulo-website/pull/400#issuecomment-1699943854
> LGTM. The styling before and after looks identical as far as I can tell.
There are a few extra stray borders and there are some slight padding differences, due to the competing styles. It would be more obvious if we customized the bootstrap table theme. I'm not suggesting we do that, but this should ensure it stays consistent with the rest of the site, if we happen to do that, and it resolves those few minor competing style issues. Thanks for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org