[GitHub] [flink] wsry opened a new pull request #10492: [FLINK-15140][runtime] Fix shuffle data compression doesn't work with BroadcastRecordWriter.

[GitBox <gi...@apache.org>]

wsry opened a new pull request #10492: [FLINK-15140][runtime] Fix shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492
 
 
   
   1. Disable data compression for operators which use broadcast partitioner in pipelined mode.
   2. Not recycle buffer if it not compressed in blocking mode.
   
   ## What is the purpose of the change
   We implemented shuffle data compression in FLINK-14845 to reduce disk and network IO, but unfortunately, a bug was introduced, which makes the compression doesn't work when broadcast partitioner is used.
   For pipelined mode, because the compressor copies the data back to the input buffer, however, the underlying buffer is shared when BroadcastRecordWriter is used. So we can not copy the compressed buffer back to the input buffer if the underlying buffer is shared. For blocking mode, we wrongly recycle the buffer when buffer is not compressed, and the problem is also triggered when BroadcastRecordWriter is used.
   This PR tries to fix the problem.
   
   
   ## Brief change log
   
     - Disable data compression for operators which use broadcast partitioner in pipelined mode.
     - Not recycle buffer if it not compressed in blocking mode.=
   
   
   ## Verifying this change
   
   ```ShuffleCompressionITCase``` is modified to cover the scenario.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services