You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2015/12/07 16:17:46 UTC
[GitHub] metamodel pull request: METAMODEL-218: Fixed
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/76
METAMODEL-218: Fixed
This fixes METAMODEL-218 by adding a few return statement in DefaultQueryRewriter.
Also updated the test template to ensure that it's working on all the databases covered by these tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-218
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 1a2a45a866b83805fd78d06281fa969b06b2d7a0
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-12-07T15:16:39Z
METAMODEL-218: Fixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by drexler42 <gi...@git.apache.org>.
Github user drexler42 commented on the pull request:
https://github.com/apache/metamodel/pull/76#issuecomment-163246456
Let's merge then!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by drexler42 <gi...@git.apache.org>.
Github user drexler42 commented on the pull request:
https://github.com/apache/metamodel/pull/76#issuecomment-163144698
Not yet, I'm afraid. Having trouble building a DataCleaner with this MM in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by drexler42 <gi...@git.apache.org>.
Github user drexler42 commented on the pull request:
https://github.com/apache/metamodel/pull/76#issuecomment-162811307
I'll give it a go and provide feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/76#issuecomment-163020477
Did you come to any conclusion @drexler42 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by drexler42 <gi...@git.apache.org>.
Github user drexler42 commented on the pull request:
https://github.com/apache/metamodel/pull/76#issuecomment-163211807
I can copy the customers table directly into Postgres now. The fix works. A word of warning though:
- MetaModel 4.4.2-SNAPSHOT is not compatible with DataCleaner master.
-- Package names of ElasticSearch datastore is changed in MM, and must be changed accordingly in DC.
-- The new MM neo4j module introduces a tattletale clash on an json library.
I excluded the culprit from DC, but then the API module does not compile anymore. I gave up on solving that at that point.
```
<dependency>
<groupId>org.apache.metamodel</groupId>
<artifactId>MetaModel-full</artifactId>
<exclusions>
<exclusion>
<artifactId>json</artifactId>
<groupId>org.apache.geronimo.bundles</groupId>
</exclusion>
</exclusions>
</dependency>
```
The fix in itself is fine. So I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-218: Fixed
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/76#issuecomment-163219986
I merged in master ... Was just a conflict in CHANGES.md. But let's see that Travis builds correctly before we merge to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---