[GitHub] [flink] zhijiangW commented on a change in pull request #8509: [FLINK-12458][network] Introduce PartitionConnectionException for unreachable producer

[GitBox <gi...@apache.org>]

zhijiangW commented on a change in pull request #8509: [FLINK-12458][network] Introduce PartitionConnectionException for unreachable producer
URL: https://github.com/apache/flink/pull/8509#discussion_r286550749
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
 ##########
 @@ -1047,6 +1047,22 @@ public void testPartitionNotFoundExceptionWhileRetriggeringRequest() throws Exce
 		}
 	}
 
+	/**
+	 * Tests that any exceptions thrown by {@link ConnectionManager#createPartitionRequestClient(ConnectionID)}
+	 * would be wrapped into {@link PartitionConnectionException} during
+	 * {@link RemoteInputChannel#requestSubpartition(int)}.
+	 */
+	@Test
+	public void testPartitionConnectionExceptionWhileRequestingPartition() throws Exception {
+		final RemoteInputChannel inputChannel = InputChannelTestUtils.createRemoteInputChannel(
+			createSingleInputGate(1), 0, new TestingExceptionConnectionManager());
+		try {
+			inputChannel.requestSubpartition(0);
 
 Review comment:
   fail is not missing on my side?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services