You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "zhang-arvin (via GitHub)" <gi...@apache.org> on 2026/09/07 17:42:11 UTC
[PR] [Bug] Skip incremental sync when delta source has no new commits [incubator-xtable]
zhang-arvin opened a new pull request, #930:
URL: https://github.com/apache/incubator-xtable/pull/930
Fixes #928
## What changes were proposed in this pull request?
`DeltaKernelConversionSource.getCommitsBacklog` computed the incremental range as `start = versionAtLastSyncInstant + 1`, `end = latestVersion` with no `start <= end` guard. With no new commits since the last sync, the range became `[n+1, n]` and Delta Kernel's `getChanges` rejected the inverted interval with `Invalid version range`, breaking the documented pattern of calling sync after every write / on a schedule.
The fix detects `versionAtLastSyncInstant >= latestVersion`, logs that there is nothing to sync, and returns an empty commits backlog, making the no-op sync successful — matching the behavior of Hudi and Parquet sources.
## How was this patch tested?
- `./mvnw -pl xtable-core -am -DskipTests compile`
- Existing `ITDeltaKernelConversionSource` / `TestDeltaKernelSync` suites cover incremental sync (local run pending CI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] Skip incremental sync when delta source has no new commits [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on PR #930:
URL: https://github.com/apache/incubator-xtable/pull/930#issuecomment-5574611551
Let's add a basic test to `xtable-core/src/test/java/org/apache/xtable/delta/ITDeltaConversionSource.java` to exercise this path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [928] Skip incremental sync when Delta source has no new commits [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on PR #930:
URL: https://github.com/apache/incubator-xtable/pull/930#issuecomment-5625480548
@the-other-tim-brown Added `testGetCommitsBacklogWithNoNewCommits` in 74a6ca74. The test uses the latest Delta commit as the sync instant and verifies that the backlog is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [928] Skip incremental sync when Delta source has no new commits [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 merged PR #930:
URL: https://github.com/apache/incubator-xtable/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [928] Skip incremental sync when Delta source has no new commits [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on PR #930:
URL: https://github.com/apache/incubator-xtable/pull/930#issuecomment-5625525344
@zhang-arvin Thanks for your first contribution! I have added the test to get this PR merged as it was blocking a team trying delta-kernel. I have added comments on your other PR's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org