You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/29 23:51:14 UTC
[GitHub] [incubator-nuttx-apps] Ouss4 opened a new pull request #698: testing/ostest: Report "ERROR" the same way for all the test cases.
Ouss4 opened a new pull request #698:
URL: https://github.com/apache/incubator-nuttx-apps/pull/698
## Summary
Report "ERROR" the same way for all the test cases. This also helps to script around the output to find out issues.
## Impact
N/A
## Testing
esp32-devkitc:ostest
esp32c3-devkit:ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #698: testing/ostest: Report "ERROR" the same way for all the test cases.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #698:
URL: https://github.com/apache/incubator-nuttx-apps/pull/698#discussion_r623516417
##########
File path: testing/ostest/mutex.c
##########
@@ -57,8 +57,15 @@
static pthread_mutex_t mut;
static volatile int my_mutex = 0;
-static unsigned long nloops[2] = {0, 0};
-static unsigned long nerrors[2] = {0, 0};
+static unsigned long nloops[2] =
+ { 0,
Review comment:
```suggestion
{
0,
```
nit: similar to the below format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #698: testing/ostest: Report "ERROR" the same way for all the test cases.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #698:
URL: https://github.com/apache/incubator-nuttx-apps/pull/698#discussion_r623724945
##########
File path: testing/ostest/mutex.c
##########
@@ -57,8 +57,15 @@
static pthread_mutex_t mut;
static volatile int my_mutex = 0;
-static unsigned long nloops[2] = {0, 0};
-static unsigned long nerrors[2] = {0, 0};
+static unsigned long nloops[2] =
+ { 0,
Review comment:
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei merged pull request #698: testing/ostest: Report "ERROR" the same way for all the test cases.
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #698:
URL: https://github.com/apache/incubator-nuttx-apps/pull/698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org