You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2024/02/16 20:59:01 UTC
Re: [PR] refactor(plugins): Time Comparison Utils [superset]
codecov[bot] commented on PR #27145:
URL: https://github.com/apache/superset/pull/27145#issuecomment-1949327169
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `3 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`dab44c0`)](https://app.codecov.io/gh/apache/superset/commit/dab44c0b6fd5f8abdf5f6d2ca613bdf7c1cbfe4d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.15% compared to head [(`a3b46bf`)](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.30%.
> Report is 1 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rt-period-over-period-kpi/src/plugin/buildQuery.ts](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGVyaW9kLW92ZXItcGVyaW9kLWtwaS9zcmMvcGx1Z2luL2J1aWxkUXVlcnkudHM=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...-period-over-period-kpi/src/plugin/controlPanel.ts](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGVyaW9kLW92ZXItcGVyaW9kLWtwaS9zcmMvcGx1Z2luL2NvbnRyb2xQYW5lbC50cw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eriod-over-period-kpi/src/plugin/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGVyaW9kLW92ZXItcGVyaW9kLWtwaS9zcmMvcGx1Z2luL3RyYW5zZm9ybVByb3BzLnRz) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #27145 +/- ##
==========================================
+ Coverage 67.15% 67.30% +0.15%
==========================================
Files 1901 1906 +5
Lines 74446 74446
Branches 8305 8300 -5
==========================================
+ Hits 49991 50109 +118
+ Misses 22402 22284 -118
Partials 2053 2053
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/27145/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/27145/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.14% <95.58%> (+0.30%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27145?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org