You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by re...@apache.org on 2015/11/22 12:53:16 UTC
[4/5] git commit: updated refs/heads/master to a3688e0
Merge pull request #1058 from greenqloud/pr/password_security
Shuffling the password to avoid having a subset of characters in fixed positions.Related to CLOUDSTACK-9052.
I am shuffling the characters in the password, to avoid having a certain char type in fixed positions. I modified the tests accordingly to only check that the different character types are present.
I think it would be good to remove the hard requirement to have at least one of digits, upper-case, and lowercase chars, as it reduces the number of possible combinations passwords can take. What do you think?
* pr/1058:
CLOUDSTACK-9052 Shuffling the password to avoid having a subset of characters in fixed positions.
Signed-off-by: Remi Bergsma <gi...@remi.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/3f7a86d8
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/3f7a86d8
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/3f7a86d8
Branch: refs/heads/master
Commit: 3f7a86d8efac3b198040be09f359727a6798dbf3
Parents: 7a77ddc 52ccfaa
Author: Remi Bergsma <gi...@remi.nl>
Authored: Sun Nov 22 12:46:31 2015 +0100
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Sun Nov 22 12:46:32 2015 +0100
----------------------------------------------------------------------
.../java/com/cloud/utils/PasswordGenerator.java | 25 +++++++++----
.../com/cloud/utils/PasswordGeneratorTest.java | 39 ++++++++++++++++----
2 files changed, 48 insertions(+), 16 deletions(-)
----------------------------------------------------------------------