You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/08/17 12:36:13 UTC
[jira] Created: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
[classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-1216
URL: http://issues.apache.org/jira/browse/HARMONY-1216
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Richard Liang
Hello,
java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
I will attach a patch to fix this issue.
Best regards,
Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1216?page=all ]
Mark Hindess reassigned HARMONY-1216:
-------------------------------------
Assignee: Mark Hindess
> [classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1216
> URL: http://issues.apache.org/jira/browse/HARMONY-1216
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Mark Hindess
> Attachments: Harmony-1216.diff
>
>
> Hello,
> java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
> I will attach a patch to fix this issue.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1216?page=all ]
Richard Liang updated HARMONY-1216:
-----------------------------------
Attachment: Harmony-1216.diff
Hello,
Would you please try this patch? Thank you.
Best regards,
Richard
> [classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1216
> URL: http://issues.apache.org/jira/browse/HARMONY-1216
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: Harmony-1216.diff
>
>
> Hello,
> java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
> I will attach a patch to fix this issue.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1216?page=comments#action_12428861 ]
Richard Liang commented on HARMONY-1216:
----------------------------------------
Hello Mark,
I use Eclipse on RHEL 4.0 to create this patch. And the two line of comments are added manually. But the patch can be applied successfully in my Eclipse. What problems have you met? Sorry.
PS. The fix looks good. Thanks a lot.
Best regards,
Richard
> [classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1216
> URL: http://issues.apache.org/jira/browse/HARMONY-1216
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Mark Hindess
> Attachments: Harmony-1216.diff
>
>
> Hello,
> java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
> I will attach a patch to fix this issue.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1216?page=all ]
Mark Hindess resolved HARMONY-1216.
-----------------------------------
Resolution: Fixed
Applied in r232235. Please check it has been applied as expected.
> [classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1216
> URL: http://issues.apache.org/jira/browse/HARMONY-1216
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Mark Hindess
> Attachments: Harmony-1216.diff
>
>
> Hello,
> java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
> I will attach a patch to fix this issue.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1216?page=all ]
Mark Hindess closed HARMONY-1216.
---------------------------------
Verified by Richard.
The unix patch tools (correctly) use the line counts as a sanity check and refuse to apply broken patches. (Eclipse should really behave like this by default IMNSHO.) I had to fix the line counts and line endings to create a consistent patch before I could apply it.
Please create patches using the proper tools (and with consistent EOL characters). Creating a patch is trivial so it's really not worth hand editing patches if you have the source - no matter how trivial it seems.
> [classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1216
> URL: http://issues.apache.org/jira/browse/HARMONY-1216
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: Mark Hindess
> Attachments: Harmony-1216.diff
>
>
> Hello,
> java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
> I will attach a patch to fix this issue.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1216) [classlib][luni]
java.io.PipedWriter.write(char[],int,int) method should throw IOException
when the corresponding thread which is reading data is no longer alive
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1216?page=comments#action_12428637 ]
Mark Hindess commented on HARMONY-1216:
---------------------------------------
How did you create this patch? The metadata for the last block reads:
@@ -237,6 +237,121 @@
but it should be:
@@ -237,6 +237,123 @@
or something like that since it adds more than 121 lines. I also notice that two lines (with the "//wait the ... thread dead" comments) have unix EOL characters which seems a little odd.
> [classlib][luni] java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1216
> URL: http://issues.apache.org/jira/browse/HARMONY-1216
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: Harmony-1216.diff
>
>
> Hello,
> java.io.PipedWriter.write(char[],int,int) method should throw IOException when the corresponding thread which is reading data is no longer alive.(Spec about PipedWriter.write(char[],int,int): If a thread was reading data characters from the connected piped input stream, but the thread is no longer alive, then an IOException is thrown.) When study this problem, I find the original problem hides in the PipedReader.receive(char[],int,int) method.There is the same problem in the PipedWriter.write(int) method.
> I will attach a patch to fix this issue.
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira