You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 18:30:38 UTC
[GitHub] [arrow] lidavidm commented on a change in pull request #11062: ARROW-13845: [C++] Reconcile RandomArrayGenerator::ArrayOf implementations
lidavidm commented on a change in pull request #11062:
URL: https://github.com/apache/arrow/pull/11062#discussion_r700463904
##########
File path: cpp/src/arrow/testing/random.cc
##########
@@ -42,6 +42,7 @@
#include "arrow/util/decimal.h"
#include "arrow/util/key_value_metadata.h"
#include "arrow/util/logging.h"
+#include "arrow/util/optional.h"
Review comment:
nit: I don't see any uses of optional/nullopt in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org