You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/14 06:53:34 UTC

[GitHub] [apisix] idbeta opened a new issue #3035: bug: del upstream but not del route, request the route, return 500

idbeta opened a new issue #3035:
URL: https://github.com/apache/apisix/issues/3035


   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ### Bug
   - Which version of Apache APISIX Dashboard, OS, and Browser?
   APISIX 2.0 + APISIX-dashbaord 2.0
   
   step1: create upstream
   step2: create route, and chose upstream created by step1
   step3: del the step1's upstream from dashboard's upstream page
   step4: request the route, return 500
   
   I think step3 should be limited.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on issue #3035: bug: del upstream but not del route, request the route, return 500

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #3035:
URL: https://github.com/apache/apisix/issues/3035#issuecomment-744296970


   Here is an example, the APISIX will return `500` if failed to load the upstream by id `upstream_id`, and will generate a error log.
   
   ```shell
   curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
       "uri": "/index.html",
       "plugins": {
           "limit-count": {
               "count": 2,
               "time_window": 60,
               "rejected_code": 503,
               "key": "remote_addr"
           }
       },
       "upstream_id": "no_exist_id"
   }'
   ```
   
   For this case, the APISIX can return `502` and write a WARN error log, should be enough


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3035: bug: del upstream but not del route, request the route, return 500

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3035:
URL: https://github.com/apache/apisix/issues/3035#issuecomment-744319303


   Yes, for DP, return 502 is enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on issue #3035: bug: del upstream but not del route, request the route, return 500

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #3035:
URL: https://github.com/apache/apisix/issues/3035#issuecomment-744297068


   @spacewander what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #3035: bug: del upstream but not del route, request the route, return 500

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #3035:
URL: https://github.com/apache/apisix/issues/3035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org