You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "ycycse (via GitHub)" <gi...@apache.org> on 2023/02/27 05:23:49 UTC
[GitHub] [iotdb] ycycse opened a new pull request, #9146: [IOTDB-5584] Fix wrong intialization in GROUP BY CONDITION
ycycse opened a new pull request, #9146:
URL: https://github.com/apache/iotdb/pull/9146
https://issues.apache.org/jira/browse/IOTDB-5584
When the controlColumn of first data point is false, conditon window wouldn't skip it because needSkip is intialized to false which leads to a redundant row in resultSet.
This PR fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #9146: [IOTDB-5584] Fix wrong intialization in GROUP BY CONDITION
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #9146:
URL: https://github.com/apache/iotdb/pull/9146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #9146: [IOTDB-5584] Fix wrong intialization in GROUP BY CONDITION
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on code in PR #9146:
URL: https://github.com/apache/iotdb/pull/9146#discussion_r1118361775
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/SeriesWindowManager.java:
##########
@@ -49,7 +49,7 @@ public class SeriesWindowManager implements IWindowManager {
public SeriesWindowManager(SeriesWindowParameter seriesWindowParameter) {
this.seriesWindow = new SeriesWindow(seriesWindowParameter);
- this.needSkip = false;
+ this.needSkip = true;
Review Comment:
add some java doc about `needSkip` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org