You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "zabetak (via GitHub)" <gi...@apache.org> on 2025/12/05 15:01:51 UTC
[PR] HIVE-29357: Change CBOPlan in EXPLAIN FORMATTED from plain string to JSON object [hive]
zabetak opened a new pull request, #6226:
URL: https://github.com/apache/hive/pull/6226
### Why are the changes needed?
Observe that value of CBOPlan is in fact a JSON object so wrapping it in a string has various drawbacks:
* Bigger size with lots of unnecessary whitespace and escaped characters
* Poor readability since it cannot be formatted by a JSON processors
* Deserialization overhead since consumers need to read the value of "CBOPlan" and retransform it to a JSON object in order to process it further
### Does this PR introduce _any_ user-facing change?
Yes, since it changes the type of the CBOPlan attribute from string to object. The change should pass mostly unnoticed since very few clients/applications are actually using the content of the CBOPlan attribute.
### How was this patch tested?
```
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=plan_json.q,excluded_rule_explain.q,materialized_view_rebuild_2.q,ctas.q,input4.q,join0.q,materialized_view_create.q,explain_ast.q,explain_locks.q,cte_cbo_plan_json.q,cbo_explain.q,authorization_explain.q,concat_op.q,tez_union.q,parallel_join0.q
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29357: Change CBOPlan in EXPLAIN FORMATTED from plain string to JSON object [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #6226:
URL: https://github.com/apache/hive/pull/6226#issuecomment-3630909737
Many thanks for the reviews everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29357: Change CBOPlan in EXPLAIN FORMATTED from plain string to JSON object [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6226:
URL: https://github.com/apache/hive/pull/6226#issuecomment-3627678143
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6226) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6226&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6226&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6226&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6226&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6226&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6226)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29357: Change CBOPlan in EXPLAIN FORMATTED from plain string to JSON object [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #6226:
URL: https://github.com/apache/hive/pull/6226#issuecomment-3619621589
LGTM +1 (non-binding), pending tests
Verified the changes in local setup.:
**Before:**
<img width="1512" height="598" alt="Before" src="https://github.com/user-attachments/assets/5f505ecf-03cb-48fe-b314-823bcc400442" />
**After:**
<img width="1511" height="393" alt="After" src="https://github.com/user-attachments/assets/215a5120-a8bf-424b-b6aa-e179e02c05f9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29357: Change CBOPlan in EXPLAIN FORMATTED from plain string to JSON object [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6226:
URL: https://github.com/apache/hive/pull/6226#issuecomment-3617545686
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6226) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6226&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6226&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6226&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6226&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6226&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6226)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29357: Change CBOPlan in EXPLAIN FORMATTED from plain string to JSON object [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak merged PR #6226:
URL: https://github.com/apache/hive/pull/6226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org