You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mosermw <gi...@git.apache.org> on 2018/08/01 20:16:42 UTC
[GitHub] nifi pull request #2931: NIFI-3531 Moved session.recover in JMSConsumer to e...
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2931
NIFI-3531 Moved session.recover in JMSConsumer to exceptional situations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi nifi-3531
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2931.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2931
----
commit 8309747889c3187005a0ce4e4c0c11b1e3281e10
Author: Mike Moser <mo...@...>
Date: 2018-08-01T20:11:35Z
NIFI-3531 Moved session.recover in JMSConsumer to exceptional situations
----
---
[GitHub] nifi issue #2931: NIFI-3531 Moved session.recover in JMSConsumer to exceptio...
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2931
The JIRA ticket mentioned a dev list conversation where Oleg said it was to limit the possibility of message loss in the event of a processor and/or NiFi crash. However, it has proven to cause problems. I have tried to kill -9 NiFi several times while ConsumeJMS is under heavy load and haven't lost a message, though perhaps I've just been lucky. The javadoc of the session.recover method doesn't seem to indicate that it should be called regularly.
The decision regarding what to do with this PR might become a risk management one, where the benefits of session.recover as it is now are unknown but the problems associated with it are known and significant.
---
[GitHub] nifi issue #2931: NIFI-3531 Moved session.recover in JMSConsumer to exceptio...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2931
do we know what the original author intended by 'abrupt end OR exceptional situations'? This change covers exceptional (JMSException anyway) but what about 'abrupt'?
---
[GitHub] nifi issue #2931: NIFI-3531 Moved session.recover in JMSConsumer to exceptio...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2931
ok @mosermw sounds fair to me.
---