You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/18 18:19:02 UTC
[GitHub] [camel] zbendhiba opened a new pull request, #8574: CAMEL-18593: Platform-http : add reverse proxy feature
zbendhiba opened a new pull request, #8574:
URL: https://github.com/apache/camel/pull/8574
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zbendhiba commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283581866
> A problem is that this is only in the vertx implementation so this will not work for others, such as with spring boot that uses servlet.
>
> So it would be good to make this clear in the documentation that currently its only supported when using camel-platform-http-vertx.
@davsclaus I've just updated the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zbendhiba commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1284045833
> @zbendhiba I wonder if you can send a PR for 3.18.x branch.
there it is : https://github.com/apache/camel/pull/8581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1282897535
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 0 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283670392
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 8 | 8 | 1 | 8 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283996690
@zbendhiba I wonder if you can send a PR for 3.18.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zbendhiba commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283919310
Yes I don't think so, All I changed since last build is the doc file.
I wonder which test is failing, can't reproduce it locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283422761
A problem is that this is only in the vertx implementation so this will not work for others, such as with spring boot that uses servlet.
So it would be good to make this clear in the documentation that currently its only supported when using camel-platform-http-vertx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283676861
Hmm there is an error in components/camel-swagger-java maybe its already there and not due to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1282826178
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8574:
URL: https://github.com/apache/camel/pull/8574#issuecomment-1283959598
yeah it passes here locally too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8574: CAMEL-18593: Platform-http : add reverse proxy feature
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8574:
URL: https://github.com/apache/camel/pull/8574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org