You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2005/10/31 19:55:09 UTC
svn commit: r329877 -
/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
Author: mmarinschek
Date: Mon Oct 31 10:55:04 2005
New Revision: 329877
URL: http://svn.apache.org/viewcvs?rev=329877&view=rev
Log:
changed cast to MyFacesResourceLoader, changed ResourceLoader.class to MyFacesResourceLoader.class
Modified:
myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java?rev=329877&r1=329876&r2=329877&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java (original)
+++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java Mon Oct 31 10:55:04 2005
@@ -152,7 +152,7 @@
*/
protected void validateResourceLoader(Class resourceloader)
{
- if (!ResourceLoader.class.isAssignableFrom(resourceloader))
+ if (!MyFacesResourceLoader.class.isAssignableFrom(resourceloader))
{
throw new FacesException("Class " + resourceloader.getName() + " must implement "
+ ResourceLoader.class.getName());
@@ -405,7 +405,7 @@
{
Class resourceLoader = getClass(className);
validateResourceLoader(resourceLoader);
- ((ResourceLoader) resourceLoader.newInstance()).serveResource(request, response,
+ ((MyFacesResourceLoader) resourceLoader.newInstance()).serveResource(request, response,
resourceUri);
response.flushBuffer();
}
Re: svn commit: r329877 - /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
Posted by Martin Marinschek <ma...@gmail.com>.
Mathias,
I did that cause my brain stopped working for half an hour ;)
regards,
Martin
On 10/31/05, Mathias Brökelmann <mb...@googlemail.com> wrote:
> Martin can you tell me why did you change this?
> The ResourceLoader was intentionally introduced to enable custom
> components which are developed by users which are not part of myfaces
> can use AddResource to serve linked resources.
>
> 2005/10/31, mmarinschek@apache.org <mm...@apache.org>:
> > Author: mmarinschek
> > Date: Mon Oct 31 10:55:04 2005
> > New Revision: 329877
> >
> > URL: http://svn.apache.org/viewcvs?rev=329877&view=rev
> > Log:
> > changed cast to MyFacesResourceLoader, changed ResourceLoader.class to MyFacesResourceLoader.class
> >
> > Modified:
> > myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
> >
> > Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
> > URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java?rev=329877&r1=329876&r2=329877&view=diff
> > ==============================================================================
> > --- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java (original)
> > +++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java Mon Oct 31 10:55:04 2005
> > @@ -152,7 +152,7 @@
> > */
> > protected void validateResourceLoader(Class resourceloader)
> > {
> > - if (!ResourceLoader.class.isAssignableFrom(resourceloader))
> > + if (!MyFacesResourceLoader.class.isAssignableFrom(resourceloader))
> > {
> > throw new FacesException("Class " + resourceloader.getName() + " must implement "
> > + ResourceLoader.class.getName());
> > @@ -405,7 +405,7 @@
> > {
> > Class resourceLoader = getClass(className);
> > validateResourceLoader(resourceLoader);
> > - ((ResourceLoader) resourceLoader.newInstance()).serveResource(request, response,
> > + ((MyFacesResourceLoader) resourceLoader.newInstance()).serveResource(request, response,
> > resourceUri);
> > response.flushBuffer();
> > }
> >
> >
> >
>
>
> --
> Mathias
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Trainings in English and German
Re: svn commit: r329877 - /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
Posted by Mathias Brökelmann <mb...@googlemail.com>.
Martin can you tell me why did you change this?
The ResourceLoader was intentionally introduced to enable custom
components which are developed by users which are not part of myfaces
can use AddResource to serve linked resources.
2005/10/31, mmarinschek@apache.org <mm...@apache.org>:
> Author: mmarinschek
> Date: Mon Oct 31 10:55:04 2005
> New Revision: 329877
>
> URL: http://svn.apache.org/viewcvs?rev=329877&view=rev
> Log:
> changed cast to MyFacesResourceLoader, changed ResourceLoader.class to MyFacesResourceLoader.class
>
> Modified:
> myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
>
> Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java
> URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java?rev=329877&r1=329876&r2=329877&view=diff
> ==============================================================================
> --- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java (original)
> +++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java Mon Oct 31 10:55:04 2005
> @@ -152,7 +152,7 @@
> */
> protected void validateResourceLoader(Class resourceloader)
> {
> - if (!ResourceLoader.class.isAssignableFrom(resourceloader))
> + if (!MyFacesResourceLoader.class.isAssignableFrom(resourceloader))
> {
> throw new FacesException("Class " + resourceloader.getName() + " must implement "
> + ResourceLoader.class.getName());
> @@ -405,7 +405,7 @@
> {
> Class resourceLoader = getClass(className);
> validateResourceLoader(resourceLoader);
> - ((ResourceLoader) resourceLoader.newInstance()).serveResource(request, response,
> + ((MyFacesResourceLoader) resourceLoader.newInstance()).serveResource(request, response,
> resourceUri);
> response.flushBuffer();
> }
>
>
>
--
Mathias