You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/16 06:44:33 UTC
[GitHub] [skywalking] hanahmily opened a new pull request, #9966: Ignore "ui_template" on checking whether a table exists
hanahmily opened a new pull request, #9966:
URL: https://github.com/apache/skywalking/pull/9966
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #9965 .
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9966: Ignore "ui_template" on checking whether a table exists
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9966:
URL: https://github.com/apache/skywalking/pull/9966#discussion_r1023564742
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -44,6 +44,9 @@ public BanyanDBIndexInstaller(Client client, ModuleManager moduleManager, Banyan
@Override
public boolean isExists(Model model) throws StorageException {
+ if (!model.isTimeSeries()) { // UITemplate
+ return true;
+ }
Review Comment:
OK, I just noticed https://github.com/apache/skywalking/issues/9965.
I think we need to update the title a little. The correct one as title and change log should be
`Fix not-time-series model blocking OAP boots in no-init mode`.
```suggestion
if (!model.isTimeSeries()) {
return true;
}
```
This comment is not necessary, we wouldn't remember to update this when we add next new not-time-series model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a diff in pull request #9966: Ignore "ui_template" on checking whether a table exists
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #9966:
URL: https://github.com/apache/skywalking/pull/9966#discussion_r1023582720
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -44,6 +44,9 @@ public BanyanDBIndexInstaller(Client client, ModuleManager moduleManager, Banyan
@Override
public boolean isExists(Model model) throws StorageException {
+ if (!model.isTimeSeries()) { // UITemplate
+ return true;
+ }
Review Comment:
Follow this line https://github.com/apache/skywalking/blob/master/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java#L90
Do I have to keep it or remove them at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9966: Fix not-time-series model blocking OAP boots in no-init mode.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9966:
URL: https://github.com/apache/skywalking/pull/9966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9966: Ignore "ui_template" on checking whether a table exists
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9966:
URL: https://github.com/apache/skywalking/pull/9966#discussion_r1023562972
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -44,6 +44,9 @@ public BanyanDBIndexInstaller(Client client, ModuleManager moduleManager, Banyan
@Override
public boolean isExists(Model model) throws StorageException {
+ if (!model.isTimeSeries()) { // UITemplate
+ return true;
+ }
Review Comment:
Why do we highlight this? The not-timer-series model would not be created in `#createTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9966: Ignore "ui_template" on checking whether a table exists
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9966:
URL: https://github.com/apache/skywalking/pull/9966#discussion_r1023597670
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -44,6 +44,9 @@ public BanyanDBIndexInstaller(Client client, ModuleManager moduleManager, Banyan
@Override
public boolean isExists(Model model) throws StorageException {
+ if (!model.isTimeSeries()) { // UITemplate
+ return true;
+ }
Review Comment:
Remove this one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org