You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/02 09:44:00 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17232: [improve][ci] Add workflow for python local install

tisonkun commented on code in PR #17232:
URL: https://github.com/apache/pulsar/pull/17232#discussion_r961497433


##########
.github/workflows/ci-python-build-3.9-client.yaml:
##########
@@ -66,3 +66,13 @@ jobs:
         run: |
           echo "Build Python3.9 client library"
           pulsar-client-cpp/docker-build-python3.9.sh
+
+      - name: Local build python client
+        if: ${{ steps.check_changes.outputs.docs_only != 'true' }}
+        uses: actions/setup-python@v4
+        with:
+          python-version: '3.9'
+        working-directory: pulsar-client-cpp/python
+        run: |
+          echo "Local build python client library"
+          pip install .

Review Comment:
   This section is incorrect and produces:
   
   ```
   a step cannot have both the `uses` and `run` keys
   ```
   
   See https://github.com/apache/pulsar/actions/runs/2978090895.
   
   I guess it will cause all PRs to fail. Please take a look @nodece @RobertIndie.
   
   Weird why it's not failed on PR CI workflows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org