You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/06 12:58:29 UTC
[GitHub] [echarts-doc] susiwen8 opened a new pull request #181: Feat(effectScatter): doc for effectScatter.clip
susiwen8 opened a new pull request #181:
URL: https://github.com/apache/echarts-doc/pull/181
Add doc for `effectScatter.clip`(https://github.com/apache/echarts/pull/14574)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a change in pull request #181: Feat(effectScatter): doc for effectScatter.clip
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #181:
URL: https://github.com/apache/echarts-doc/pull/181#discussion_r608312548
##########
File path: en/option/partial/clip.md
##########
@@ -12,6 +12,7 @@
If clip the overflow on the coordinate system. Clip results varies between series:
+ Scatter：Ignore the symbols exceeds the coordinate system. Not clip the elements.
++ EffectScatter the symbols exceeds the coordinate system. Not clip the elements.
Review comment:
It seems there is missing `: Ignore`.
BTW, may these two series be merged as `Scatter/EffectScatter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang merged pull request #181: Feat(effectScatter): doc for effectScatter.clip
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #181:
URL: https://github.com/apache/echarts-doc/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] susiwen8 commented on a change in pull request #181: Feat(effectScatter): doc for effectScatter.clip
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #181:
URL: https://github.com/apache/echarts-doc/pull/181#discussion_r608330178
##########
File path: en/option/partial/clip.md
##########
@@ -12,6 +12,7 @@
If clip the overflow on the coordinate system. Clip results varies between series:
+ Scatter：Ignore the symbols exceeds the coordinate system. Not clip the elements.
++ EffectScatter the symbols exceeds the coordinate system. Not clip the elements.
Review comment:
> may these two series be merged as Scatter/EffectScatter
Yes, I think that would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org