You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 12:44:55 UTC

[GitHub] [airflow-site] ashb opened a new pull request #339: Add theme options to theme.conf

ashb opened a new pull request #339:
URL: https://github.com/apache/airflow-site/pull/339


   Rather than using custom config properties, and then putting them in to
   the theme context, this uses Sphinx's built in mechanism that
   automatically exposes every option in `theme.conf` with a `theme_`
   prefix.
   
   This commit will make a bit more sense in a second as I am going to add a few more options in here.
   
   I will follow up with a PR to update apache-airflow too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] ashb commented on a change in pull request #339: Add theme options to theme.conf

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #339:
URL: https://github.com/apache/airflow-site/pull/339#discussion_r539288252



##########
File path: sphinx_airflow_theme/sphinx_airflow_theme/theme.conf
##########
@@ -6,3 +6,6 @@ pygments_style = default
 [options]
 canonical_url =
 analytics_id =
+# Default set by python code, need to list this here to avoid warning from Sphinx
+navbar_links =

Review comment:
       Will update docs, you can't specify dict in here (but shpinx warns if this isn't here), so you have to set it via conf.py in end user (airflow)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] ashb merged pull request #339: Add theme options to theme.conf

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #339:
URL: https://github.com/apache/airflow-site/pull/339


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] ashb commented on a change in pull request #339: Add theme options to theme.conf

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #339:
URL: https://github.com/apache/airflow-site/pull/339#discussion_r539289702



##########
File path: sphinx_airflow_theme/sphinx_airflow_theme/theme.conf
##########
@@ -6,3 +6,6 @@ pygments_style = default
 [options]
 canonical_url =
 analytics_id =
+# Default set by python code, need to list this here to avoid warning from Sphinx
+navbar_links =

Review comment:
       Done, PTAL.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-site] mik-laj commented on a change in pull request #339: Add theme options to theme.conf

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #339:
URL: https://github.com/apache/airflow-site/pull/339#discussion_r539285958



##########
File path: sphinx_airflow_theme/sphinx_airflow_theme/theme.conf
##########
@@ -6,3 +6,6 @@ pygments_style = default
 [options]
 canonical_url =
 analytics_id =
+# Default set by python code, need to list this here to avoid warning from Sphinx
+navbar_links =

Review comment:
       How can I set a dictionary here? Can you update docs? https://github.com/apache/airflow-site/tree/master/sphinx_airflow_theme#configuration




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org