You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "wenbingshen (via GitHub)" <gi...@apache.org> on 2023/05/20 06:53:40 UTC

[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3964: [WIP][improve] Force ReSchedule Auditor tasks

wenbingshen opened a new pull request, #3964:
URL: https://github.com/apache/bookkeeper/pull/3964

   ### Motivation
   
   This PR follows up the comments in this PR #3945 
   
   Now when we manually trigger auditor check, we need to restart Auditor or trigger a round of auditor election to take effect.
   
   So I hope we can trigger auditor check more smoothly. Support for Auditor Tasks rescheduling is available.
   
   ### Changes
   
   By registering the specified zk node, the callback logic of Auditor tasks rescheduling is triggered.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] wenbingshen commented on pull request #3964: [improve] Force Reschedule Auditor tasks

Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3964:
URL: https://github.com/apache/bookkeeper/pull/3964#issuecomment-1628331520

   > The function is still quite complicated,or add a BP to discuss?
   
   @StevenLuMT Thanks. I have started a BP to discuss it. 
   BP #4025 
   email: https://lists.apache.org/thread/w1rqy6t2jr3qrrzxjh14rjllpgw97v98


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] StevenLuMT commented on pull request #3964: [improve] Force Reschedule Auditor tasks

Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #3964:
URL: https://github.com/apache/bookkeeper/pull/3964#issuecomment-1617696272

   The function is still quite complicated, or add a BP to discuss?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] wenbingshen commented on pull request #3964: [improve] Force Reschedule Auditor tasks

Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3964:
URL: https://github.com/apache/bookkeeper/pull/3964#issuecomment-1588482000

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] wenbingshen commented on pull request #3964: [improve] Force Reschedule Auditor tasks

Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3964:
URL: https://github.com/apache/bookkeeper/pull/3964#issuecomment-1561321819

   @hangc0276 @horizonzy @zymap @StevenLuMT
   This PR is ready for review.
   I have improved the remaining functions & add metric & add trigger cmd and unit tests & add Auditor unit tests.
   PTAL. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] wenbingshen commented on pull request #3964: [improve] Force Reschedule Auditor tasks

Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3964:
URL: https://github.com/apache/bookkeeper/pull/3964#issuecomment-1592404377

   @hangc0276 Can we include this future in 4.16.2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org