[jira] [Commented] (TAP5-1879) grid component has 'add' parameter, rename 'exclude' to 'remove' to keep semantics consistent

["Felix Scheffer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119838#comment-14119838 ] 

Felix Scheffer commented on TAP5-1879:
--------------------------------------

I think the naming is consistent. There is an "include" parameter and the opposite is therefore called "exclude". The "add" parameter adds additional column that are not part of the bean.

Also renaming the "exclude" parameter would probably break lots of applications.

-1

> grid component has 'add' parameter, rename 'exclude' to 'remove' to keep semantics consistent
> ---------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1879
>                 URL: https://issues.apache.org/jira/browse/TAP5-1879
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.3.2
>            Reporter: Paul Stanton
>            Priority: Trivial
>              Labels: grid
>
> the grid component can 'add' columns via the 'add' parameter. It would make sense then to have a matching 'remove' parameter to remove columns added by default. However this parameter is currently named 'exclude'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)