You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/03/28 20:15:27 UTC
Review Request 58003: Add disable security option to infra-solr-client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
Bugs: AMBARI-20611
https://issues.apache.org/jira/browse/AMBARI-20611
Repository: ambari
Description
-------
New solr-client command: unsecure-znode
Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
Diffs
-----
ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
Diff: https://reviews.apache.org/r/58003/diff/1/
Testing
-------
done.
Thanks,
Oliver Szabo
Re: Review Request 58003: Add disable security option to
infra-solr-client
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/#review170369
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On March 29, 2017, 9:55 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58003/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 9:55 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-20611
> https://issues.apache.org/jira/browse/AMBARI-20611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> New solr-client command: unsecure-znode
>
> Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
>
>
> Diffs
> -----
>
> ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58003/diff/2/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58003: Add disable security option to
infra-solr-client
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/#review170371
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On March 29, 2017, 10:13 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58003/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 10:13 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-20611
> https://issues.apache.org/jira/browse/AMBARI-20611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> New solr-client command: unsecure-znode
>
> Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
>
>
> Diffs
> -----
>
> ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58003/diff/3/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58003: Add disable security option to
infra-solr-client
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/
-----------------------------------------------------------
(Updated March 29, 2017, 10:13 a.m.)
Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
Changes
-------
add command
Bugs: AMBARI-20611
https://issues.apache.org/jira/browse/AMBARI-20611
Repository: ambari
Description
-------
New solr-client command: unsecure-znode
Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
Diffs (updated)
-----
ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
Diff: https://reviews.apache.org/r/58003/diff/3/
Changes: https://reviews.apache.org/r/58003/diff/2-3/
Testing
-------
done.
Thanks,
Oliver Szabo
Re: Review Request 58003: Add disable security option to
infra-solr-client
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/#review170370
-----------------------------------------------------------
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
Lines 184 (patched)
<https://reviews.apache.org/r/58003/#comment243187>
I can't find from where is the unsecureZnode() is called. Should be somewhere inside the switch case?
- Attila Magyar
On March 29, 2017, 9:55 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58003/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 9:55 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-20611
> https://issues.apache.org/jira/browse/AMBARI-20611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> New solr-client command: unsecure-znode
>
> Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
>
>
> Diffs
> -----
>
> ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58003/diff/2/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58003: Add disable security option to
infra-solr-client
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/
-----------------------------------------------------------
(Updated March 29, 2017, 9:55 a.m.)
Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
Changes
-------
fix acl
Bugs: AMBARI-20611
https://issues.apache.org/jira/browse/AMBARI-20611
Repository: ambari
Description
-------
New solr-client command: unsecure-znode
Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
Diffs (updated)
-----
ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
Diff: https://reviews.apache.org/r/58003/diff/2/
Changes: https://reviews.apache.org/r/58003/diff/1-2/
Testing
-------
done.
Thanks,
Oliver Szabo
Re: Review Request 58003: Add disable security option to
infra-solr-client
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58003/#review170367
-----------------------------------------------------------
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java
Lines 42 (patched)
<https://reviews.apache.org/r/58003/#comment243185>
shouldn't the permision be crdwa, instead of read?
- Attila Magyar
On March 28, 2017, 8:15 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58003/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 8:15 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-20611
> https://issues.apache.org/jira/browse/AMBARI-20611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> New solr-client command: unsecure-znode
>
> Later that will replace current disable security mechanism (solr-client will be renamed to solr-zk-client) as this module has more options and commands regarding to zookeeper operations. This first patch is just about introducing the same command that is used in ZkMigrator. (also upgrade zookeeper dependency)
>
>
> Diffs
> -----
>
> ambari-infra/ambari-infra-solr-client/pom.xml 1a3733a
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 5cde9ea
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java ff28664
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UnsecureZNodeZkCommand.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58003/diff/1/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Oliver Szabo
>
>