You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by dp...@apache.org on 2017/07/20 11:52:59 UTC
logging-log4net git commit: (doc) Contributing: fixed markup syntax
of unordered lists
Repository: logging-log4net
Updated Branches:
refs/heads/develop 35ef4bb34 -> 620ecfcd4
(doc) Contributing: fixed markup syntax of unordered lists
Project: http://git-wip-us.apache.org/repos/asf/logging-log4net/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4net/commit/620ecfcd
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4net/tree/620ecfcd
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4net/diff/620ecfcd
Branch: refs/heads/develop
Commit: 620ecfcd4e266677df47b6407c608232c48155e1
Parents: 35ef4bb
Author: Dominik Psenner <dp...@apache.org>
Authored: Thu Jul 20 13:52:31 2017 +0200
Committer: Dominik Psenner <dp...@apache.org>
Committed: Thu Jul 20 13:52:31 2017 +0200
----------------------------------------------------------------------
CONTRIBUTING.md | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4net/blob/620ecfcd/CONTRIBUTING.md
----------------------------------------------------------------------
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 984a5e4..47a1a9c 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -8,8 +8,8 @@ You have found a bug or you have an idea for a cool new feature? Contributing co
* Make sure you have a [GitHub account](https://github.com/signup/free).
* If you're planning to implement a new feature it makes sense to discuss the changes on the [development mailing list](https://logging.apache.org/log4net/mail-lists.html) first. This way you can make sure you are not wasting your time on something that isn't considered to be in Apache log4net's scope.
* Submit a ticket for your issue, assuming one does not already exist.
-** Clearly describe the issue including steps to reproduce when it is a bug.
-** Make sure you fill in the earliest version that you know has the issue.
+ * Clearly describe the issue including steps to reproduce when it is a bug.
+ * Make sure you fill in the earliest version that you know has the issue.
* Fork the repository on GitHub.
# Contributing changes
@@ -17,8 +17,8 @@ You have found a bug or you have an idea for a cool new feature? Contributing co
* Create a topic branch from where you want to base your work (this is usually the develop branch).
* Make commits of logical units.
* Respect the original code style:
-** Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-** Check for unnecessary whitespace with git diff --check before committing.
+ * Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
+ * Check for unnecessary whitespace with git diff --check before committing.
* Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
* Make sure you have added the necessary tests for your changes.
* Run all the tests with `nant` inside the `tests` directory to assure nothing else was accidentally broken. Please note that not all targets can be built on a single machine and therefore only a subset of the actual targets is built and tested.