[GitHub] [druid] capistrant commented on a change in pull request #11036: request logs through kafka emitter

[GitBox <gi...@apache.org>]

capistrant commented on a change in pull request #11036:
URL: https://github.com/apache/druid/pull/11036#discussion_r605209281



##########
File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java
##########
@@ -166,6 +184,10 @@ public void emit(final Event event)
           if (!alertQueue.offer(objectContainer)) {
             alertLost.incrementAndGet();
           }
+        } else if (event instanceof RequestLogEvent && config.getRequestTopic() != null) {

Review comment:
       one question, why not still use `requestLost` as the counter for lost events instead of putting them in the bucket of `invalid` events which seems to be there for cases where the object isn't a supported event type?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org