You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/10/21 08:52:34 UTC

[GitHub] [camel-k] phantomjinx opened a new pull request #2711: Refactors e2e testing to allow for platform delegation

phantomjinx opened a new pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711


   * Allows a repo to select underlying platform, ie. kind, minishift o
     custom, where latter is guided by secrets located in the private repo
   
   * Refactors duplicate steps into actions so pairing down the content of the
     workflow
   
   * Utilises inputs and outputs to actions for action-action and action-workflow
     comms
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1025536191


   @phantomjinx totally agree! monumental! many thanks! 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-994675439


   @astefanutti @christophd 
   At the stage where I'm confident that the refactor is working correctly. Tests that are failing seem to be either problematic tests (@squakez already working on kubernetes metric test I think). Not sure what's up with `yaks`.
   Probably needs a final review then merge? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-994684435


   @phantomjinx awesome!
   
   For the metrics e2e test, it's fixed with #2833, so you may want to rebase. For YAKS tests, I think we need @christophd eagle eyes :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1013344090


   > Rebased with latest main -> [5e9d1e8](https://github.com/apache/camel-k/commit/5e9d1e891717bd9103838d01c557bc5480dc7c4f)
   
   Thanks a lot for the heads up. Let's have this merged in priority once the 1.8.0 release is out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1024194018


   @phantomjinx I was about to ask whether you were ready to have this merged :) This is good to go for me 👍🏼.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-994684435


   @phantomjinx awesome!
   
   For the metrics e2e test, it's fixed with #2833 and #2836, so you may want to rebase. For YAKS tests, I think we need @christophd eagle eyes :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r737605833



##########
File path: .github/actions/kamel-config-cluster-custom/action.yml
##########
@@ -0,0 +1,119 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       > Just for precision, we've already decomissioned Minishift #2428 as it doesn't work any more and what we are still using for `openshift.yml` is OpenShift 3 `oc cluster up`, which is another way to set up an OCP 3 cluster locally.
   
   I thought it looked unlike minishift. I'll rename actions accordingly. Thx!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1009745308


   @phantomjinx thanks. I'd suggest to wait for @christophd feedback, and have this merged after the upcoming 1.8.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792465826



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       I'll set this test as problematic then and back out the olm-operator permission role.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1022033591


   > > I'm holding off #2939 to avoid yet another conflict with this.
   > 
   > I have already taken into account the 'wrong' change so I can easily update this, especially as I'll do another rebase to fix the truthiness of the report-problematic action. So feel free to merge #2939.
   
   Awesome, thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1021142369


   Rebased and all checks passed (finally!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1013328930


   Rebased with latest main -> 5e9d1e8917


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1014836131


   https://github.com/phantomjinx/camel-k/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1021142369


   Rebased and all checks passed (finally!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx removed a comment on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx removed a comment on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-950934727


   @christophd 
   Are you able to give some steerage on why the one yaks test is consistently failing please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx edited a comment on pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx edited a comment on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-950934727


   @christophd 
   Are you able to give some steerage on why the one yaks test is consistently failing please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r733521860



##########
File path: .github/actions/kamel-config-cluster-minishift/action.yml
##########
@@ -0,0 +1,152 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       No problems with that ... see above. Upshot is perhaps just a little too far with the changes already in this commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1024163950


   @astefanutti 
   Any thoughts on what else we'd like to see in this before committing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1024920445


   > @phantomjinx I was about to ask whether you were ready to have this merged :) This is good to go for me 👍🏼.
   
   Tests still fail on OCP4 and I have the problematic tests to work on but the failures seem random like the test runs here upstream. So, would like to merge and then keep working on fixes on main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1025509356


   > Tests still fail on OCP4 and I have the problematic tests to work on but the failures seem random like the test runs here upstream. So, would like to merge and then keep working on fixes on main.
   
   Sounds good, let's merge it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792026301



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       There is a [tecton test](https://github.com/apache/camel-k/blob/main/e2e/common/tekton_test.go) which installs kamel and is executed by the camel-k-operator service-account. On OCP, the OLM is available hence it tries to install via the mechanism but throws permission errors as the SA has no privileges for subscriptions etc... Therefore, this role allows this test to pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792026301



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       There is a [tecton test](https://github.com/apache/camel-k/blob/main/e2e/common/tekton_test.go) which installs kamel, executed by the camel-k-operator service-account. On OCP, the OLM is available hence it tries to install via the mechanism but throws permission errors as the SA has no privileges for subscriptions etc... Therefore, this role allows this test to pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1022032524


   > I'm holding off #2939 to avoid yet another conflict with this.
   
   I have already taken into account the 'wrong' change so I can easily update this, especially as I'll do another rebase to fix the truthiness of the report-problematic action. So feel free to merge #2939.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792413705



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       We aim at keeping the set of permissions for the operator reduced to the minimum. Extra permissions for OLM resources are not needed by the operator, only by the account that's used to run the Kamel CLI install command.  In the Tekton test case, it seems the problem is two folds:
   * The test re-use the `camel-k-operator` ServiceAccount, while it should create one dedicated to calling the Kamel CLI,
   * The test runs the install command, but I doubt it's a real use case. Usually, Tekton pipelines would run integrations, not install Camel K.
   
   They are some documentation available at https://camel.apache.org/camel-k/1.8.x/tutorials/tekton/tekton.html. That being said, I doubt this feature has ever been actually used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792403216



##########
File path: e2e/common/operator_metrics_test.go
##########
@@ -171,6 +172,17 @@ func TestMetrics(t *testing.T) {
 			))
 		})
 
+		/*
+		 * TODO
+		 * The duration_seconds tests keep randomly failing on OCP4 with slightly different duration values
+		 * May need to lessen the strict checking parameters
+		 *
+		 * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+		 */
+		if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {

Review comment:
       Ah, I checked the Kubernetes workflow logs and saw:
   ```
   === Problematic Tests (7) ===
     ./e2e/common/cli/dev_mode_test.go::TestRunDevMode
     ./e2e/common/cli/dev_mode_test.go::TestRunDevMode
     ./e2e/common/operator_metrics_test.go::TestMetrics
     ./e2e/common/operator_metrics_test.go::TestMetrics
     ./e2e/common/traits/health_test.go::TestHealthTrait
     ./e2e/common/traits/toleration_test.go::TestTolerationTrait
     ./e2e/common/traits/route_test.go::TestRunRoutes
   ===
   ```
   I assumed the tests got skipped as a result, but they are indeed executed later on. Maybe the problematic tests listing could be skipped when `CAMEL_K_TEST_SKIP_PROBLEMATIC` is not truthy.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-950934727


   @christophd 
   Are you ablve to give some steerage on why the one yaks test is consistently failing please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1025509923


   Thanks for this monumental work 🚀!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1014832414


   @phantomjinx @astefanutti I guess we have improved the YAKS test from failed to flaky which is a start.
   
   @phantomjinx I have an open PR on your branch which might turn this one into a stable test 🤞  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792471960



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       Sounds good 👍🏼.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792023934



##########
File path: e2e/common/operator_metrics_test.go
##########
@@ -171,6 +172,17 @@ func TestMetrics(t *testing.T) {
 			))
 		})
 
+		/*
+		 * TODO
+		 * The duration_seconds tests keep randomly failing on OCP4 with slightly different duration values
+		 * May need to lessen the strict checking parameters
+		 *
+		 * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+		 */
+		if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {

Review comment:
       That is the case. Only in the nightly OCP test suite is CAMEL_K_TEST_SKIP_PROBLEMATIC set to "true". Upstream is empty.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti merged pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1010837866


   unfortunately `-w` option did not fix the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1009165235


   @astefanutti 
   
   Down to the yaks test in KNative suite consistently failing (any ideas @christophd appreciated??).
   
   Otherwise, will try to fix the tests I've labelled as PROBLEMATIC unless you would like to go ahead and merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1009734203


   @phantomjinx I take a look at the yaks test and let you know


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1010062356


   @squakez thanks! 
   
   I believe the workflow is doing something like this
   
   ```
   kamel install --cluster-setup
   
   
   kamel install -n $YAKS_NAMESPACE
   ```
   
   Where the cluster setup is done for namespace `default` and the 2nd install is done in a test namespace. The 2nd install command should install the Camel K operator and the Integration Platform right? 
   
   So right after the install the test starts and creates the integration. Maybe this is a racing condition where the Integration Platform has not been fully created yet but the test is already referencing a Kamelet?
   
   We can add `-w` option to the 2nd install command to make sure we wait for the platform to be running.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1009994478


   > Why there is no IntegrationPlatform created as part of `kamel install`?
   
   When `global` we must explicitly install the `IntegrationPlatform` via `kamel install --ski-operator-setup` in the namespace we want to be watched.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1010075345


   > @squakez thanks!
   > 
   > I believe the workflow is doing something like this
   > 
   > ```
   > kamel install --cluster-setup
   > 
   > 
   > kamel install -n $YAKS_NAMESPACE
   > ```
   > 
   > Where the cluster setup is done for namespace `default` and the 2nd install is done in a test namespace. The 2nd install command should install the Camel K operator and the Integration Platform right?
   > 
   > So right after the install the test starts and creates the integration. Maybe this is a racing condition where the Integration Platform has not been fully created yet but the test is already referencing a Kamelet?
   > 
   > We can add `-w` option to the 2nd install command to make sure we wait for the platform to be running.
   
   Possibly. It makes sense to wait for the second install to finish, so we should have all the needed stuff for executing a test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r733521219



##########
File path: .github/actions/kamel-config-cluster-custom/action.yml
##########
@@ -0,0 +1,119 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       The presence of minishift is purely to continune the tests in their current configuration while completing this refactor. My aim has not been initially to discontinue with minishift but to refactor the tests to allow for the proposal of midstream private repos with custom cluster configurations. Certainly, we can drop minishift and I've already has some preliminary discussions with @astefanutti & @christophd about deduplicating the `kubernetes.yml` & `openshift.yml` but I have been careful not to step too far along with my work so far.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r733521860



##########
File path: .github/actions/kamel-config-cluster-minishift/action.yml
##########
@@ -0,0 +1,152 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       No problems with that ... see above. Upshot is perhaps just a little too far with the changes already in this commit.
   Also, minishift has provided at least an existing a stable mechanism for bringing up an ephemeral openshift cluster on the runner itself. So was at least good for testing with while doing this refactor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1012095130


   Maybe waiting for the IntegrationPlatform is not enough. I have added a `kubectl wait` that explicitly waits for the timer-source Kamelet to be ready. Let's see if this helps.
   
   @phantomjinx https://github.com/phantomjinx/camel-k/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez edited a comment on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
squakez edited a comment on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1010075345


   > 
   > We can add `-w` option to the 2nd install command to make sure we wait for the platform to be running.
   
   Possibly. It makes sense to wait for the second install to finish, so we should have all the needed stuff for executing a test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez edited a comment on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
squakez edited a comment on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1009994478


   > Why there is no IntegrationPlatform created as part of `kamel install`?
   
   When `global` we must explicitly install the `IntegrationPlatform` via `kamel install --skip-operator-setup` in the namespace we want to be watched.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] tadayosi commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r737093495



##########
File path: .github/actions/kamel-config-cluster-custom/action.yml
##########
@@ -0,0 +1,119 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       Just for precision, we've already decomissioned Minishift #2428 as it doesn't work any more and what we are still using for `openshift.yml` is OpenShift 3 `oc cluster up`, which is another way to set up an OCP 3 cluster locally.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] tadayosi commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r737093495



##########
File path: .github/actions/kamel-config-cluster-custom/action.yml
##########
@@ -0,0 +1,119 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       Just for precision, we've already decomissioned #2428 and what we are still using for `openshift.yml` is OpenShift 3 `oc cluster up`, which is another way to set up an OCP 3 cluster locally.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-994810813


   > @phantomjinx awesome!
   > 
   > For the metrics e2e test, it's fixed with #2833 and #2836, so you may want to rebase. For YAKS tests, I think we need @christophd eagle eyes :)
   
   Looks like the metrics fix may have sorted it for kind but now failing for openshift:
   ```
   Expected
               <uint>: 12
           to be ==
               <uint64>: 11
   ```
   
   @squakez 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-994684435


   @phantomjinx awesome. For the metrics e2e test, it's fixed with #2833, so you may want to rebase. For YAKS tests, I think we need @christophd eagle eyes :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-994819846


   @phantomjinx that's hopefully fixed with #2836.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r791727889



##########
File path: e2e/common/traits/health_test.go
##########
@@ -35,7 +36,18 @@ import (
 	v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
 )
 
+/*
+ * TODO
+ * Test needs to be modified as route for unsecured http is not created on OCP.

Review comment:
       It seems the comment is taken from the route trait tests. This test do not create a Route.

##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       What is this new role for? I fail to see why it should be bound to the operator ServiceAccount.

##########
File path: e2e/common/operator_metrics_test.go
##########
@@ -171,6 +172,17 @@ func TestMetrics(t *testing.T) {
 			))
 		})
 
+		/*
+		 * TODO
+		 * The duration_seconds tests keep randomly failing on OCP4 with slightly different duration values
+		 * May need to lessen the strict checking parameters
+		 *
+		 * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+		 */
+		if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {

Review comment:
       Could the problematic tests be deactivated only on OCP4? Most of them run fine on other environments, so it'd be better not to disable them globally in the interim.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r791727889



##########
File path: e2e/common/traits/health_test.go
##########
@@ -35,7 +36,18 @@ import (
 	v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
 )
 
+/*
+ * TODO
+ * Test needs to be modified as route for unsecured http is not created on OCP.

Review comment:
       It seems the comment is taken from the route trait tests. This test do not create a Route.

##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       What is this new role for? I fail to see why it should be bound to the operator ServiceAccount.

##########
File path: e2e/common/operator_metrics_test.go
##########
@@ -171,6 +172,17 @@ func TestMetrics(t *testing.T) {
 			))
 		})
 
+		/*
+		 * TODO
+		 * The duration_seconds tests keep randomly failing on OCP4 with slightly different duration values
+		 * May need to lessen the strict checking parameters
+		 *
+		 * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+		 */
+		if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {

Review comment:
       Could the problematic tests be deactivated only on OCP4? Most of them run fine on other environments, so it'd be better not to disable them globally in the interim.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792026301



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       There is a tecton test which installs kamel and is executed by the camel-k-operator service-account. On OCP, the OLM is available hence it tries to install via the mechanism but throws permission errors as the SA has no privileges for subscriptions etc... Therefore, this role allows this test to pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1021984269


   I'm holding off #2939 to avoid yet another conflict with this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r733521219



##########
File path: .github/actions/kamel-config-cluster-custom/action.yml
##########
@@ -0,0 +1,119 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       **Update**
   While what I've said is true below, I didn't realise it was the custom action that you were commenting on. That comes down to a copy 'n paste error which has now been corrected. Sorry!
   
   The presence of minishift is purely to continune the tests in their current configuration while completing this refactor. My aim has not been initially to discontinue with minishift but to refactor the tests to allow for the proposal of midstream private repos with custom cluster configurations. Certainly, we can drop minishift and I've already has some preliminary discussions with @astefanutti & @christophd about deduplicating the `kubernetes.yml` & `openshift.yml` but I have been careful not to step too far along with my work so far.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez commented on a change in pull request #2711: Refactors e2e testing to allow for platform delegation

Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r733482239



##########
File path: .github/actions/kamel-config-cluster-custom/action.yml
##########
@@ -0,0 +1,119 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       Would it be something specific to `minishift`? I thought we were no longer supporting it.

##########
File path: .github/actions/kamel-config-cluster-minishift/action.yml
##########
@@ -0,0 +1,152 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: kamel-config-cluster-minishift

Review comment:
       As commented above, shouldn't we drop `minishift`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1010181350


   > @squakez thanks!
   > 
   
   Thx for looking into this @christophd 
   
   > I believe the workflow is doing something like this
   > 
   > ```
   > kamel install --cluster-setup
   > 
   > 
   > kamel install -n $YAKS_NAMESPACE
   > ```
   > 
   > Where the cluster setup is done for namespace `default` and the 2nd install is done in a test namespace. The 2nd install command should install the Camel K operator and the Integration Platform right?
   > 
   
   The first command is not really doing anything for the `default` namespace since `--cluster-setup` is only responsible for installing cluster-level resources, ie. cluster-roles and CRDS.
   
   > So right after the install the test starts and creates the integration. Maybe this is a racing condition where the Integration Platform has not been fully created yet but the test is already referencing a Kamelet?
   > 
   > We can add `-w` option to the 2nd install command to make sure we wait for the platform to be running.
   
   Will look further into this ....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] phantomjinx commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
phantomjinx commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792026301



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       There is a [tecton test](https://github.com/apache/camel-k/blob/main/e2e/common/tekton_test.go) which installs kamel, executed by the camel-k-operator service-account. On OCP, the OLM is available hence it tries to install via that mechanism but throws permission errors as the SA has no privileges for subscriptions etc... Therefore, this role allows this test to pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r792413705



##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
 - user-cluster-role.yaml
 - operator-role-events.yaml
 - operator-role-knative.yaml
+- operator-role-olm.yaml

Review comment:
       We aim to keep the set of permissions for the operator reduced to the minimum. Extra permissions for OLM resources are not needed by the operator, only by the account that's used to run the Kamel CLI install command.  In the Tekton test case, it seems the problem is two folds:
   * The test re-use the `camel-k-operator` ServiceAccount, while it should create one dedicated to calling the Kamel CLI,
   * The test runs the install command, but I doubt it's a real use case. Usually, Tekton pipelines would run integrations, not install Camel K.
   
   They are some documentation available at https://camel.apache.org/camel-k/1.8.x/tutorials/tekton/tekton.html. That being said, I doubt this feature has ever been actually used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #2711: E2E development allowing injection of secrets denoting testing on custom clusters

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#issuecomment-1009781896


   so I have had a look and there is one test failing `apache-kamelet-catalog`
   
   So the test installs Camel K in a new namespace via `kamel install` and then tries to start an integration with a Kamelet `timer-source` being used. The IntegrationPlatform seems to not be available in the namespace and therefore no Kamelets available. This is why the test fails because it can not find `timer-source` Kamelet when running the integration.
   
   Here is the log
   
   ```
   YAKS operator installation completed
   YAKS installed in namespace default  (global mode)
   Creating new test namespace yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf
   Unable to find existing YAKS instance - adding new operator instance to temporary namespace by default
   Added Knative addon to YAKS operator in namespace 'yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf'
   Added CamelK addon to YAKS operator in namespace 'yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf'
   Running installation:
   OLM is not available in the cluster. Fallback to regular installation.
   Camel K installed in namespace yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf 
   Integration "logger" created
   Progress: integration "logger" in phase Waiting For Platform
   Condition "IntegrationPlatformAvailable" is "False" for Integration logger: yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf/camel-k
   Integration "logger" in phase "Waiting For Platform"
   Cannot reconcile Integration logger: error during trait customization: kamelets  found, timer-source not found in repositories: (Kubernetes[namespace=yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf], Empty[])
   Failed to run installation: 
   signal: killed
   AutoRemove namespace yaks-67cb9fc4-99bf-4c17-a157-73169c06cacf
   ```
   
   Why there is no IntegrationPlatform created as part of `kamel install`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org