You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by anmolnar <gi...@git.apache.org> on 2018/05/08 22:09:54 UTC

[GitHub] zookeeper pull request #514: ZOOKEEPER-3012. Fix unit test: testDataDirAndDa...

GitHub user anmolnar opened a pull request:

    https://github.com/apache/zookeeper/pull/514

    ZOOKEEPER-3012. Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders

    A little bit more than just fixing the hardcoded folder names. Because the original issue was only on the 3.4 branch, the unit test has also been added to that branch only.
    
    In this PR I add the fixed version of test to the master branch. Should be committed to 3.5 as well and I'll create a separate PR for 3.4

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3012

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #514
    
----
commit 15ff7951701a55d2b9e94af6d4dd73288a2c51a4
Author: Andor Molnar <an...@...>
Date:   2018-05-08T22:04:23Z

    ZOOKEEPER-3012. Added unit test to validate dataDir and dataLogDir params

----


---

[GitHub] zookeeper pull request #514: ZOOKEEPER-3012. Fix unit test: testDataDirAndDa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/514


---

[GitHub] zookeeper issue #514: ZOOKEEPER-3012. Fix unit test: testDataDirAndDataLogDi...

Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/514
  
    +1, thanks @anmolnar 


---