You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/08/08 05:41:05 UTC
[GitHub] [activemq-artemis] odidev opened a new pull request #3240: Upgrade to Netty 4.1.50.Final and netty-tcnative 2.0.31.Final
odidev opened a new pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240
Upgrade netty and netty-tcnative to its latest version which includes for security fixes and AArch64 performance improvements.
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
Signed-off-by: odidev <od...@puresoftware.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3240: Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-700011252
You need a JIRA like this https://issues.apache.org/jira/browse/ARTEMIS-2727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] odidev commented on pull request #3240: ARTEMIS-2921:Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
odidev commented on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-701189640
I have done squash and amend as suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3240: ARTEMIS-2921:Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-700717117
@odidev can you squash and amend your commits according to https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#typical-development-cycle ?
Everything else looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] odidev removed a comment on pull request #3240: Upgrade to Netty 4.1.50.Final and netty-tcnative 2.0.31.Final
Posted by GitBox <gi...@apache.org>.
odidev removed a comment on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-671241417
"Upgraded surefire to 3.0.0-M5 due to compatibility and to let integration tests work"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3240: Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#discussion_r495944567
##########
File path: pom.xml
##########
@@ -127,7 +127,7 @@
<version.maven.jar.plugin>2.4</version.maven.jar.plugin>
<version.micrometer>1.1.4</version.micrometer>
<hamcrest.version>2.1</hamcrest.version>
- <surefire.version>2.22.2</surefire.version>
+ <surefire.version>3.0.0-M5</surefire.version>
Review comment:
Why are you changing the surefire version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] odidev commented on pull request #3240: Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
odidev commented on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-699809232
Hi Team,
Please review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] odidev commented on pull request #3240: Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
odidev commented on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-686307473
Hi Team,
Please review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3240: ARTEMIS-2921:Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] odidev commented on pull request #3240: Upgrade to Netty 4.1.50.Final and netty-tcnative 2.0.31.Final
Posted by GitBox <gi...@apache.org>.
odidev commented on pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#issuecomment-671241417
"Upgraded surefire to 3.0.0-M5 due to compatibility and to let integration tests work"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] odidev commented on a change in pull request #3240: ARTEMIS-2921:Upgrade to Netty 4.1.51.Final and netty-tcnative 2.0.33.Final
Posted by GitBox <gi...@apache.org>.
odidev commented on a change in pull request #3240:
URL: https://github.com/apache/activemq-artemis/pull/3240#discussion_r496697293
##########
File path: pom.xml
##########
@@ -127,7 +127,7 @@
<version.maven.jar.plugin>2.4</version.maven.jar.plugin>
<version.micrometer>1.1.4</version.micrometer>
<hamcrest.version>2.1</hamcrest.version>
- <surefire.version>2.22.2</surefire.version>
+ <surefire.version>3.0.0-M5</surefire.version>
Review comment:
@brusdev
Yes, I agree with you and verified that in this package, surefire update is not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org