[GitHub] [beam] CraigChambersG commented on pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

[GitBox <gi...@apache.org>]

CraigChambersG commented on pull request #12880:
URL: https://github.com/apache/beam/pull/12880#issuecomment-696219024


   Yes, that should be the case, on v2.  Dataflow v2 can handle
   heterogeneously typed Flattens.
   
   On Mon, Sep 21, 2020 at 9:10 AM Lukasz Cwik <no...@github.com>
   wrote:
   
   > *@lukecwik* commented on this pull request.
   > ------------------------------
   >
   > In sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
   > <https://github.com/apache/beam/pull/12880#discussion_r492181015>:
   >
   > > @@ -430,6 +430,15 @@ def _check_for_unsupported_fnapi_features(self, pipeline_proto):
   >                  components.coders[windowing_strategy.window_coder_id].spec.urn,
   >                  windowing_strategy.window_fn.urn))
   >
   > +  def _adjust_types_for_dataflow(self, pipeline):
   > +    # Dataflow runner requires a KV type for GBK inputs, hence we enforce that
   > +    # here.
   > +    pipeline.visit(self.group_by_key_input_visitor())
   > +
   > +    # Dataflow runner requires output type of the Flatten to be the same as the
   >
   > @CraigChambersG <https://github.com/CraigChambersG> I was under the
   > impression that this wasn't true and that Dataflow v2 handled this.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/12880#pullrequestreview-492771941>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AKXWJXCTMD5YB2IIFZ5PAHLSG53HVANCNFSM4RTFTKVA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org