You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/10/31 01:56:14 UTC

[jira] [Created] (HBASE-7077) checkAndPut should properly integrate with MVCC

Gregory Chanan created HBASE-7077:
-------------------------------------

             Summary: checkAndPut should properly integrate with MVCC
                 Key: HBASE-7077
                 URL: https://issues.apache.org/jira/browse/HBASE-7077
             Project: HBase
          Issue Type: Sub-task
            Reporter: Gregory Chanan
             Fix For: 0.96.0


checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.

Also need a test, here's one we could use (originally proposed in HBASE-7051):
The current value of some cell is 10.
I issue two concurrent requests:
A) a check and put where check value = 10, put value = 11
B) a put where put value = 50
The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) checkAndPut should properly integrate with MVCC

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487565#comment-13487565 ] 

ramkrishna.s.vasudevan commented on HBASE-7077:
-----------------------------------------------

I will try to write a testcase for this.  That day i reproduced with debugging.
                
> checkAndPut should properly integrate with MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7077) checkAndPut should properly integrate with MVCC

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-7077:
------------------------------------------

    Attachment: HBASE-7071.patch

Testcase that shows the problem.
                
> checkAndPut should properly integrate with MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-7077:
---------------------------------

    Fix Version/s: 0.94.3
    
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490389#comment-13490389 ] 

Hudson commented on HBASE-7077:
-------------------------------

Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
    HBASE-7077 ADDENDUM, add TestCategory (Revision 1404641)
HBASE-7077 Test for: CheckAndPut should properly read MVCC (Ram) (Revision 1404383)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java

larsh : 
Files : 
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) checkAndPut should properly integrate with MVCC

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488192#comment-13488192 ] 

Gregory Chanan commented on HBASE-7077:
---------------------------------------

The test references HBASE-7071, but that is not related.  Change it to reference HBASE-7051?
                
> checkAndPut should properly integrate with MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan reassigned HBASE-7077:
---------------------------------------------

    Assignee: ramkrishna.s.vasudevan
    
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488814#comment-13488814 ] 

Hudson commented on HBASE-7077:
-------------------------------

Integrated in HBase-TRUNK #3504 (See [https://builds.apache.org/job/HBase-TRUNK/3504/])
    HBASE-7077 ADDENDUM, add TestCategory (Revision 1404640)

     Result = FAILURE
larsh : 
Files : 
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java

                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-7077:
---------------------------------

    Summary: Test for: CheckAndPut should properly read MVCC  (was: Test for: checkAndPut should properly integrate with MVCC)
    
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7077) Test for: checkAndPut should properly integrate with MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-7077:
---------------------------------

    Summary: Test for: checkAndPut should properly integrate with MVCC  (was: checkAndPut should properly integrate with MVCC)
    
> Test for: checkAndPut should properly integrate with MVCC
> ---------------------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488580#comment-13488580 ] 

Hudson commented on HBASE-7077:
-------------------------------

Integrated in HBase-TRUNK #3503 (See [https://builds.apache.org/job/HBase-TRUNK/3503/])
    HBASE-7077 Test for: CheckAndPut should properly read MVCC (Revision 1404382)

     Result = FAILURE
larsh : 
Files : 
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488514#comment-13488514 ] 

Hudson commented on HBASE-7077:
-------------------------------

Integrated in HBase-0.94 #562 (See [https://builds.apache.org/job/HBase-0.94/562/])
    HBASE-7077 Test for: CheckAndPut should properly read MVCC (Ram) (Revision 1404383)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488757#comment-13488757 ] 

Lars Hofhansl commented on HBASE-7077:
--------------------------------------

fixed
                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7077) checkAndPut should properly integrate with MVCC

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-7077:
------------------------------------------

    Attachment: HBASE-7071_testcasewithassert.patch

Same testcase with some refactoring and assertion.
                
> checkAndPut should properly integrate with MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488784#comment-13488784 ] 

Hudson commented on HBASE-7077:
-------------------------------

Integrated in HBase-0.94 #563 (See [https://builds.apache.org/job/HBase-0.94/563/])
    HBASE-7077 ADDENDUM, add TestCategory (Revision 1404641)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java

                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489242#comment-13489242 ] 

Hudson commented on HBASE-7077:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #247 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/247/])
    HBASE-7077 ADDENDUM, add TestCategory (Revision 1404640)

     Result = FAILURE
larsh : 
Files : 
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java

                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) checkAndPut should properly integrate with MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488172#comment-13488172 ] 

Lars Hofhansl commented on HBASE-7077:
--------------------------------------

Nice test Ram! I verified that it passes with the patch on HBASE-7051 and fails without it.
                
> checkAndPut should properly integrate with MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl resolved HBASE-7077.
----------------------------------

    Resolution: Fixed

Committed to 0.94 and 0.96. Thanks for the nice test Ram.
(I change the test name to TestHBase7051)
                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) checkAndPut should properly integrate with MVCC

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488270#comment-13488270 ] 

Lars Hofhansl commented on HBASE-7077:
--------------------------------------

I'll make that change and commit the test. I verified that it validates the fix in HBASE-7051 correctly.

                
> checkAndPut should properly integrate with MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7077) Test for: CheckAndPut should properly read MVCC

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488669#comment-13488669 ] 

Ted Yu commented on HBASE-7077:
-------------------------------

There is no test category for the test which resulted in trunk build failure. 
                
> Test for: CheckAndPut should properly read MVCC
> -----------------------------------------------
>
>                 Key: HBASE-7077
>                 URL: https://issues.apache.org/jira/browse/HBASE-7077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Gregory Chanan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-7071.patch, HBASE-7071_testcasewithassert.patch
>
>
> checkAndPut should integrate with MVCC, similar to how HBASE-4583 fixed appends and increments.
> Also need a test, here's one we could use (originally proposed in HBASE-7051):
> The current value of some cell is 10.
> I issue two concurrent requests:
> A) a check and put where check value = 10, put value = 11
> B) a put where put value = 50
> The only result at the end of these operations that seems reasonable to me is the value of the cell being 50. If A occurred first (ACID wise), then our values go 10->11->50. If B occurred first, then our values go 10->50 (and the checkAndPut fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira