You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/05/18 16:12:02 UTC
[GitHub] [spark] wangyum opened a new pull request, #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
wangyum opened a new pull request, #41219:
URL: https://github.com/apache/spark/pull/41219
### What changes were proposed in this pull request?
This PR upgrades `cyclonedx-maven-plugin` to 2.7.9.
### Why are the changes needed?
Fix compile errors running on Java 20+:
```
Error: Failed to execute goal org.cyclonedx:cyclonedx-maven-plugin:2.7.6:makeBom (default) on project spark-tags_2.12: Execution default of goal org.cyclonedx:cyclonedx-maven-plugin:2.7.6:makeBom failed: Unsupported class file major version 64 -> [Help 1]
```
The issue fixed by `cyclonedx-maven-plugin` 2.7.7. Please see: https://github.com/CycloneDX/cyclonedx-maven-plugin/issues/326.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553862383
2.7.9 also contains other bug fixes and improvements:
https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.9
https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.8
https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553807202
I'd like to find a failed test case to add to https://github.com/Homebrew/homebrew-core/pull/131189.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553861234
Maybe, you want to hide `cyclonedx-maven-plugin` under a profile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553728429
If you don't mind, let's hold on this PR because Java 20 is not our real target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553857614
Well, `cyclonedx-maven-plugin` is not a test case. Also, it's used at release process, not a runtime.
> I'd like to find a failed test case to add to https://github.com/Homebrew/homebrew-core/pull/131189.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553903460
Do you think Apache Spark's SBOM artifacts are affected by one of them?
> 2.7.9 also contains other bug fixes and improvements:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553692887
I tested it through Java 20.
Before: https://github.com/wangyum/spark/actions/runs/5015734585/jobs/8991701615
After: https://github.com/wangyum/spark/actions/runs/5015807076/jobs/8992120361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553947929
Thank you for closing. We can reopen this when `master` branch is ready for `Java 21` and we are able to verify this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
URL: https://github.com/apache/spark/pull/41219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41219: [SPARK-43577][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.9
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41219:
URL: https://github.com/apache/spark/pull/41219#issuecomment-1553945799
OK. so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org