You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michael Gottschalk (JIRA)" <ji...@apache.org> on 2010/03/02 10:45:27 UTC
[jira] Commented: (WICKET-2737) reduce number of
SpringBeanLocator#getBeanNameOfClass calls.
[ https://issues.apache.org/jira/browse/WICKET-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840082#action_12840082 ]
Michael Gottschalk commented on WICKET-2737:
--------------------------------------------
The patch does not seem to be present in the SVN repository yet.
So why is this bug fixed/resolved? Should it not be reopened?
> reduce number of SpringBeanLocator#getBeanNameOfClass calls.
> -------------------------------------------------------------
>
> Key: WICKET-2737
> URL: https://issues.apache.org/jira/browse/WICKET-2737
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-spring
> Affects Versions: 1.4.3
> Reporter: Zbigniew Ruchała
> Assignee: Juergen Donnerstag
> Fix For: 1.4.7, 1.5-M1
>
> Attachments: AnnotProxyFieldValueFactory.java, patch.txt
>
>
> In our application we use @SpringBean *without* name given extensively. It causes performance problems due to the fact that each time SpringBeanLocator uses its #getBeanNameOfClass method to look up a bean name within aplicationContext. Our inhouse improvement for this is to cache bean name for once localized bean in AnnotProxyFieldValueFactory. An instance of SpringBeanLocator gest always beanName in constructor. I attached the source code. It speeded up our app about 40%.
> The attached file provides improvement for 1.4.3 version.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.