[GitHub] [spark] LuciferYang commented on a diff in pull request #39598: [SPARK-41708][SQL][FOLLOWUP] Override `equals` and `hashCode` of `TableIdentifier` to make `CatalogFileIndex` print the same results when using Scala 2.12 and 2.13

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #39598:
URL: https://github.com/apache/spark/pull/39598#discussion_r1070893144


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala:
##########
@@ -104,6 +104,13 @@ case class TableIdentifier(table: String, database: Option[String], catalog: Opt
 
   def this(table: String) = this(table, None, None)
   def this(table: String, database: Option[String]) = this(table, database, None)
+
+  override def equals(obj: Any): Boolean = obj match {

Review Comment:
   cc @cloud-fan @HyukjinKwon @dongjoon-hyun @ulysses-you 
   
   The daily build GA `Master Scala 2.13 + Hadoop 3 + JDK 8` failed after https://github.com/apache/spark/pull/39468 merged.
   
   - https://github.com/apache/spark/actions/runs/3924877161
   - https://github.com/apache/spark/actions/runs/3919886270
   - https://github.com/apache/spark/actions/runs/3914162890
   - https://github.com/apache/spark/actions/runs/3905252989
   - https://github.com/apache/spark/actions/runs/3895875210
   - https://github.com/apache/spark/actions/runs/3895875210
   
   Are there any suggestions for better solutions? For example, override `toString` of `CatalogFileIndex`? What is better to print?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org