You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2026/07/21 15:51:26 UTC

[PR] Build: Test Parquet 1.18.0 [iceberg]

Fokko opened a new pull request, #17321:
URL: https://github.com/apache/iceberg/pull/17321

   Devlist: https://lists.apache.org/thread/fx96wnmkbmx7pcz2h89t592ztc8bcrn1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.0 [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #17321:
URL: https://github.com/apache/iceberg/pull/17321#discussion_r3744870106


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -169,9 +170,13 @@ public void testMetricsMissingColumnStatisticsInRowGroups() throws IOException {
     // Null count, lower and upper bounds should be empty because
     // one of the statistics in row groups is missing
     Metrics metrics = ParquetUtil.fileMetrics(inputFile, MetricsConfig.getDefault());
-    assertThat(metrics.nullValueCounts()).isEmpty();
-    assertThat(metrics.lowerBounds()).isEmpty();
-    assertThat(metrics.upperBounds()).isEmpty();
+    assertThat(metrics.nullValueCounts()).hasSize(1);
+
+    assertThat(metrics.lowerBounds()).hasSize(1);
+    assertThat(metrics.lowerBounds().get(1)).isEqualTo(Conversions.toByteBuffer(Types.StringType.get(), "test"));
+
+    assertThat(metrics.upperBounds()).hasSize(1);
+    assertThat(metrics.upperBounds().get(1)).isEqualTo(Conversions.toByteBuffer(Types.StringType.get(), "test"));

Review Comment:
   This has been reverted in https://github.com/apache/parquet-java/pull/3688



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.0 [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #17321:
URL: https://github.com/apache/iceberg/pull/17321#issuecomment-5490779799

   Testing out 1.18.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.1 [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #17321:
URL: https://github.com/apache/iceberg/pull/17321#discussion_r3971927087


##########
build.gradle:
##########
@@ -117,6 +117,9 @@ allprojects {
   repositories {
     mavenCentral()
     mavenLocal()
+    maven {
+      url = uri("https://repository.apache.org/content/groups/staging/")
+    }

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.1 [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #17321: Build: Test Parquet 1.18.1
URL: https://github.com/apache/iceberg/pull/17321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.0 [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #17321:
URL: https://github.com/apache/iceberg/pull/17321#issuecomment-5478785197

   I agree with @RussellSpitzer, I'll probably cut a Parquet RC later today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.0 [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #17321:
URL: https://github.com/apache/iceberg/pull/17321#discussion_r3641772062


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -169,9 +170,13 @@ public void testMetricsMissingColumnStatisticsInRowGroups() throws IOException {
     // Null count, lower and upper bounds should be empty because
     // one of the statistics in row groups is missing
     Metrics metrics = ParquetUtil.fileMetrics(inputFile, MetricsConfig.getDefault());
-    assertThat(metrics.nullValueCounts()).isEmpty();
-    assertThat(metrics.lowerBounds()).isEmpty();
-    assertThat(metrics.upperBounds()).isEmpty();
+    assertThat(metrics.nullValueCounts()).hasSize(1);
+
+    assertThat(metrics.lowerBounds()).hasSize(1);
+    assertThat(metrics.lowerBounds().get(1)).isEqualTo(Conversions.toByteBuffer(Types.StringType.get(), "test"));
+
+    assertThat(metrics.upperBounds()).hasSize(1);
+    assertThat(metrics.upperBounds().get(1)).isEqualTo(Conversions.toByteBuffer(Types.StringType.get(), "test"));

Review Comment:
   I think I feel a bit uncomfortable with the change introduced in https://github.com/apache/parquet-java/pull/3575. I don't think the upper- and lower bounds are correct, since the value for the long string is truncated, and it should be part of the stats (or completely omit it like before).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Test Parquet 1.18.1 [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #17321:
URL: https://github.com/apache/iceberg/pull/17321#issuecomment-5903486147

   @Fokko Could you please rebase this PR and get it in to unblock #18318?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org