You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/21 23:10:27 UTC

[GitHub] [hadoop] anuengineer commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient

anuengineer commented on issue #1329: HDDS-738. Removing REST protocol support from OzoneClient
URL: https://github.com/apache/hadoop/pull/1329#issuecomment-523683749
 
 
   There are some minor issues, otherwise, it looks quite good.
   1. Unit test failure looks connected to this patch.
     ```
      [ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 2.141 s <<< FAILURE! - in org.apache.hadoop.ozone.s3.TestOzoneClientProducer
   [ERROR] testGetClientFailure[0](org.apache.hadoop.ozone.s3.TestOzoneClientProducer)  Time elapsed: 0.58 s  <<< FAILURE!
   java.lang.AssertionError: 
    Expected to find 'Couldn't create protocol ' but got unexpected exception: java.io.IOException: Couldn't create RpcClient protocol
   	at org.apache.hadoop.ozone.client.OzoneClientFactory.getClientProtocol(OzoneClientFactory.java:207)
      
   ```
   
   2. The Checkstyle issues -- mostly unused imports.
   3. One minor JavaDoc.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org