You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/23 06:46:21 UTC
[GitHub] [incubator-kyuubi] zinking commented on a change in pull request #2193: [KYUUBI #1915] invoke tpcds from sql
zinking commented on a change in pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#discussion_r832900917
##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/zorder/ZorderSqlExtensions.g4
##########
@@ -76,6 +82,11 @@ comparisonOperator
: EQ | NEQ | NEQJ | LT | LTE | GT | GTE | NSEQ
;
+expression
Review comment:
I am okay calling it argument. and agree it's a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org