You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/04 01:39:54 UTC

Review Request 29564: Knox service components should indicate security state

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29564/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-8899
    https://issues.apache.org/jira/browse/AMBARI-8899


Repository: ambari


Description
-------

The Knox service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND. 


Diffs
-----

  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py f578926 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py 880c617 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 760f826 
  ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py be423fa 
  ambari-server/src/test/python/stacks/2.2/configs/secured.json deea45f 

Diff: https://reviews.apache.org/r/29564/diff/


Testing
-------

Manually tested in test cluster

Added unit tests

#Jenkins test results:

test_configure_default (test_knox_gateway.TestKnoxGateway) ... ok
**test_security_status (test_knox_gateway.TestKnoxGateway) ... ok**

----------------------------------------------------------------------
Ran 2 tests in 0.048s

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:07 h
[INFO] Finished at: 2015-01-04T00:13:34+00:00
[INFO] Final Memory: 44M/537M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Re: Review Request 29564: Knox service components should indicate security state

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29564/#review66918
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Jan. 4, 2015, 12:39 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29564/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 12:39 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8899
>     https://issues.apache.org/jira/browse/AMBARI-8899
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Knox service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py f578926 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py 880c617 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 760f826 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py be423fa 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json deea45f 
> 
> Diff: https://reviews.apache.org/r/29564/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> 
> Added unit tests
> 
> #Jenkins test results:
> 
> test_configure_default (test_knox_gateway.TestKnoxGateway) ... ok
> **test_security_status (test_knox_gateway.TestKnoxGateway) ... ok**
> 
> ----------------------------------------------------------------------
> Ran 2 tests in 0.048s
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:07 h
> [INFO] Finished at: 2015-01-04T00:13:34+00:00
> [INFO] Final Memory: 44M/537M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>