[GitHub] [incubator-singa] pinpom commented on a change in pull request #522: SINGA 475 - add And operator

[GitBox <gi...@apache.org>]

pinpom commented on a change in pull request #522: SINGA 475 - add And operator
URL: https://github.com/apache/incubator-singa/pull/522#discussion_r315022274
 
 

 ##########
 File path: python/singa/autograd.py
 ##########
 @@ -2319,3 +2319,24 @@ def backward(self, dy):
 def max(a,b):
     return Max()(a,b)[0]
 
+
+class And(Operation):
+    def __init__(self):
+        super(And, self).__init__()
+
+    def forward(self, a, b):
+        m = singa.__div__(a,b)
 
 Review comment:
   i assume a/0 = un-defined. so in both cases, mask0 = singa.GEFloat(m,1) & mask1 = singa.LEFloat(m,1) return 0 for any element of a/0. the test also passed when b has 0s (b = np.array([0, -0.3, 0, 0.1, 0.5, 0.9])). 
   I am not sure if in computing there is error when trying to compute a/0? please help to advise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services