You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by deepakddixit <gi...@git.apache.org> on 2017/05/11 10:14:16 UTC
[GitHub] geode pull request #509: GEODE-265: Removing deprecated API from Execution i...
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/509
GEODE-265: Removing deprecated API from Execution interface.
- Removed following deprecated API from Execution interface
1. public Execution<IN, OUT, AGG> withArgs(IN args)
2. public ResultCollector<?, ?> execute(String functionId, boolean hasResult)
throws FunctionException
3. public ResultCollector<?, ?> execute(String functionId, boolean hasResult, boolean isHA)
throws FunctionException;
4. public ResultCollector<?, ?> execute(String functionId, boolean hasResult, boolean isHA,
boolean optimizeForWrite) throws FunctionException
- Removed implementation of these deprecated API's
- Fixed RollingUpgrade2DUnitTest.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
----
commit e0493d67567abc9fcd8071f91031e3834d788884
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-08T11:04:59Z
GEODE-265 : Removing deprecated API's from Execution interface.
In addition to execute method variants removed withArgs method which is deprecated as well.
commit 426d74a536f4ef4fc6c336c020f1de269bd7fe66
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-10T12:44:24Z
GEODE-265 : Removing implementation of methods which are deprecated and are removed from Execution interface.
commit 834ef9e7160755fd7f95d58393f1d63f41cb8332
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-11T09:44:58Z
GEODE-269 : Fixing RollingUpgrade2DUnitTest. After removing deprecated API withArgs, setArgument alternative API is not available in older version of server causing NoSuchMethodFound exception. The role of setArgument with function is passing class name to load inside the function. As the relevant function is used on in the context of this test, instead of using setArgument method made class name as a field in GetDataSerializableFunction.
commit c628e701ae35fc6c298c0d3893bdbf14c4a32df8
Author: Deepak Dixit <de...@gmail.com>
Date: 2017-05-11T10:09:46Z
GEODE-269 : SpotlessApply changes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Posted by deepakddixit <gi...@git.apache.org>.
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/509
@metatype Thanks for review. I have removed withArgs related changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Posted by jhuynh1 <gi...@git.apache.org>.
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/509
@metatype Will do for both this and PR#511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Posted by jhuynh1 <gi...@git.apache.org>.
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/509
I think these changes are ok (I didn't check when these were deprecated but I assume @metatype already did the grunt work on it. I can merge these changes in if no one has any other reviews
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #509: GEODE-265: Removing deprecated API from Execution i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/509
Thanks for your contribution!
If I'm reading the log correctly, `withArgs(IN args)` was deprecated one month ago. We should *not* remove this from the public API until the next major version (e.g. 2.0.0). In the future when we deprecate an API it would be helpful to mark *when* it was deprecated to help track this more explicitly. Can you remove this from the changeset?
```
commit aaef124e3d4d7b46c82ddb4d2af65ee48b73ba53
Author: Alyssa Kim <mi...@gmail.com>
Date: Sat Apr 15 17:48:00 2017 -0700
GEODE-728: Rename Execution.withArgs to Execution.setArguments
* created setArguments
* deprecated withArgs
* implemented setArguments of all Execution implementations in Geode project
* replaced all of withArgs with setArguments
This closes #457
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/509
@jhuynh1 I just noticed the one recent deprecation. Given this is a public API change you should probably double-check me :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---