You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/08 12:09:52 UTC
[GitHub] [arrow] jpedroantunes opened a new pull request #10479: ARROW-13006: [C++][Gandiva] Implement BASE64 and UNBASE64 Hive functions on Gandiva
jpedroantunes opened a new pull request #10479:
URL: https://github.com/apache/arrow/pull/10479
Implement BASE64 and UNBASE64 Hive functions on Gandiva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10479: ARROW-13006: [C++][Gandiva] Implement BASE64 and UNBASE64 Hive functions on Gandiva
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10479:
URL: https://github.com/apache/arrow/pull/10479#issuecomment-856709700
https://issues.apache.org/jira/browse/ARROW-13006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] praveenbingo closed pull request #10479: ARROW-13006: [C++][Gandiva] Implement BASE64 and UNBASE64 Hive functions on Gandiva
Posted by GitBox <gi...@apache.org>.
praveenbingo closed pull request #10479:
URL: https://github.com/apache/arrow/pull/10479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] projjal commented on a change in pull request #10479: ARROW-13006: [C++][Gandiva] Implement BASE64 and UNBASE64 Hive functions on Gandiva
Posted by GitBox <gi...@apache.org>.
projjal commented on a change in pull request #10479:
URL: https://github.com/apache/arrow/pull/10479#discussion_r659333734
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -302,6 +303,61 @@ char* gdv_fn_dec_to_string(int64_t context, int64_t x_high, uint64_t x_low,
return ret;
}
+GANDIVA_EXPORT
+const char* gdv_fn_base64_encode_binary(int64_t context, const char* in, int32_t in_len,
+ int32_t* out_len) {
+ if (in_len < 0) {
+ gdv_fn_context_set_error_msg(context, "Buffer length can not be negative");
+ *out_len = 0;
+ return "";
+ }
+ if (in_len == 0) {
+ *out_len = 0;
+ return "";
+ }
+ // use arrow method to encode base64 string
+ std::string encoded_str =
+ arrow::util::base64_encode(reinterpret_cast<const unsigned char*>(in), in_len);
+ *out_len = static_cast<int32_t>(encoded_str.length());
+ // allocate memory for response
+ char* ret = reinterpret_cast<char*>(
+ gdv_fn_context_arena_malloc(context, static_cast<int32_t>(*out_len)));
+ if (ret == nullptr) {
+ gdv_fn_context_set_error_msg(context, "Could not allocate memory");
+ *out_len = 0;
+ return "";
+ }
+ memcpy(ret, encoded_str.data(), *out_len);
+ return ret;
+}
+
+GANDIVA_EXPORT
+const char* gdv_fn_base64_decode_utf8(int64_t context, const char* in, int32_t in_len,
+ int32_t* out_len) {
+ if (in_len < 0) {
+ gdv_fn_context_set_error_msg(context, "Buffer length can not be negative");
+ *out_len = 0;
+ return "";
+ }
+ if (in_len == 0) {
+ *out_len = 0;
+ return "";
+ }
+ // use arrow method to decode base64 string
+ std::string decoded_str = arrow::util::base64_decode(in);
Review comment:
This seems incorrect. It will assume null terminated string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jpedroantunes commented on a change in pull request #10479: ARROW-13006: [C++][Gandiva] Implement BASE64 and UNBASE64 Hive functions on Gandiva
Posted by GitBox <gi...@apache.org>.
jpedroantunes commented on a change in pull request #10479:
URL: https://github.com/apache/arrow/pull/10479#discussion_r659705047
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -302,6 +303,61 @@ char* gdv_fn_dec_to_string(int64_t context, int64_t x_high, uint64_t x_low,
return ret;
}
+GANDIVA_EXPORT
+const char* gdv_fn_base64_encode_binary(int64_t context, const char* in, int32_t in_len,
+ int32_t* out_len) {
+ if (in_len < 0) {
+ gdv_fn_context_set_error_msg(context, "Buffer length can not be negative");
+ *out_len = 0;
+ return "";
+ }
+ if (in_len == 0) {
+ *out_len = 0;
+ return "";
+ }
+ // use arrow method to encode base64 string
+ std::string encoded_str =
+ arrow::util::base64_encode(reinterpret_cast<const unsigned char*>(in), in_len);
+ *out_len = static_cast<int32_t>(encoded_str.length());
+ // allocate memory for response
+ char* ret = reinterpret_cast<char*>(
+ gdv_fn_context_arena_malloc(context, static_cast<int32_t>(*out_len)));
+ if (ret == nullptr) {
+ gdv_fn_context_set_error_msg(context, "Could not allocate memory");
+ *out_len = 0;
+ return "";
+ }
+ memcpy(ret, encoded_str.data(), *out_len);
+ return ret;
+}
+
+GANDIVA_EXPORT
+const char* gdv_fn_base64_decode_utf8(int64_t context, const char* in, int32_t in_len,
+ int32_t* out_len) {
+ if (in_len < 0) {
+ gdv_fn_context_set_error_msg(context, "Buffer length can not be negative");
+ *out_len = 0;
+ return "";
+ }
+ if (in_len == 0) {
+ *out_len = 0;
+ return "";
+ }
+ // use arrow method to decode base64 string
+ std::string decoded_str = arrow::util::base64_decode(in);
Review comment:
You are right! I built the "in" string now considering its length on it. Now it not assumes the nulltermination
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org