[jira] [Work logged] (TEXT-153) LookupTranslator performance optimization

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TEXT-153?focusedWorklogId=207431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207431 ]

ASF GitHub Bot logged work on TEXT-153:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Mar/19 21:05
            Start Date: 04/Mar/19 21:05
    Worklog Time Spent: 10m 
      Work Description: amirhadadi commented on pull request #108: TEXT-153: Make prefixSet a BitSet.
URL: https://github.com/apache/commons-text/pull/108
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 207431)
            Time Spent: 10m
    Remaining Estimate: 0h

> LookupTranslator performance optimization
> -----------------------------------------
>
>                 Key: TEXT-153
>                 URL: https://issues.apache.org/jira/browse/TEXT-153
>             Project: Commons Text
>          Issue Type: Improvement
>    Affects Versions: 1.0
>            Reporter: Amir Hadadi
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When using Java Mission Control to profile an application that uses StringEscapeUtils::escapeEcmaScript, I noticed that a lot of time is spent in LookupTranslator::translate at the prefixSet::contains check.
> I suggest taking advantage of the fact that prefixSet contains only characters, and replace it with a BitSet.
> I did some benchmarking and translate for the non escaped case is 4-5X faster when replacing the HashSet with a BitSet.
> BitSet Memory consumption for characters is capped at 8KB, and depends on the maximal prefix character. For example for ECMA script the max escaped prefix character is "\" which has unicode code 92 so the BitSet uses a long array of length 2 to represent all the needed characters.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)