You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Rajpara <dh...@gmail.com> on 2018/05/22 12:57:59 UTC
Review Request 67234: RANGER-2102: Popup,
Date picker and Dropdown list of select field remains open on-click of a
back button from browser.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67234/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Mehul Parikh, Nitin Galave, and Velmurugan Periasamy.
Bugs: RANGER-2102
https://issues.apache.org/jira/browse/RANGER-2102
Repository: ranger
Description
-------
It is reproduced in most of the case where modals/popups/dropdown list are used in the page.
Few cases are mention below:
1) Click on policy validity period in policy create page and hit the back button of the browser, popup remains open.
2) Click any drop-down list throughout in Ranger UI and simply press back button of the browser, the drop-down list remains open.
3) Click on date-selector throughout in Ranger UI and press back button of the browser, date-selector remains open.
Diffs
-----
security-admin/src/main/webapp/scripts/utils/XAUtils.js cf33e18
security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 6038895
security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 0d1c92f
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4158309
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2e925a9
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 118abf0
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b55d57e
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js b463938
security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 54444fb
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 840374f
Diff: https://reviews.apache.org/r/67234/diff/1/
Testing
-------
1) Tested that Popup gets closed on policy period page after user clicks on back button.
2) Tested that Dropdown gets closed on Ranger UI after user clicks on back button.
3) Tested that Datepicker gets closed on Ranger UI after user clicks on back button.
Thanks,
Dhaval Rajpara
Re: Review Request 67234: RANGER-2102: Popup,
Date picker and Dropdown list of select field remains open on-click of a
back button from browser.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67234/#review203657
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 22, 2018, 12:57 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67234/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 12:57 p.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Nitin Galave, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2102
> https://issues.apache.org/jira/browse/RANGER-2102
>
>
> Repository: ranger
>
>
> Description
> -------
>
> It is reproduced in most of the case where modals/popups/dropdown list are used in the page.
> Few cases are mention below:
> 1) Click on policy validity period in policy create page and hit the back button of the browser, popup remains open.
> 2) Click any drop-down list throughout in Ranger UI and simply press back button of the browser, the drop-down list remains open.
> 3) Click on date-selector throughout in Ranger UI and press back button of the browser, date-selector remains open.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/utils/XAUtils.js cf33e18
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 6038895
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 0d1c92f
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4158309
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2e925a9
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 118abf0
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b55d57e
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js b463938
> security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 54444fb
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 840374f
>
>
> Diff: https://reviews.apache.org/r/67234/diff/1/
>
>
> Testing
> -------
>
> 1) Tested that Popup gets closed on policy period page after user clicks on back button.
> 2) Tested that Dropdown gets closed on Ranger UI after user clicks on back button.
> 3) Tested that Datepicker gets closed on Ranger UI after user clicks on back button.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 67234: RANGER-2102: Popup,
Date picker and Dropdown list of select field remains open on-click of a
back button from browser.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67234/#review203645
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Galave
On May 22, 2018, 12:57 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67234/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 12:57 p.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Nitin Galave, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2102
> https://issues.apache.org/jira/browse/RANGER-2102
>
>
> Repository: ranger
>
>
> Description
> -------
>
> It is reproduced in most of the case where modals/popups/dropdown list are used in the page.
> Few cases are mention below:
> 1) Click on policy validity period in policy create page and hit the back button of the browser, popup remains open.
> 2) Click any drop-down list throughout in Ranger UI and simply press back button of the browser, the drop-down list remains open.
> 3) Click on date-selector throughout in Ranger UI and press back button of the browser, date-selector remains open.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/utils/XAUtils.js cf33e18
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 6038895
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 0d1c92f
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4158309
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2e925a9
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 118abf0
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b55d57e
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js b463938
> security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 54444fb
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 840374f
>
>
> Diff: https://reviews.apache.org/r/67234/diff/1/
>
>
> Testing
> -------
>
> 1) Tested that Popup gets closed on policy period page after user clicks on back button.
> 2) Tested that Dropdown gets closed on Ranger UI after user clicks on back button.
> 3) Tested that Datepicker gets closed on Ranger UI after user clicks on back button.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>