[jira] [Commented] (AMQ-5597) AMQP: clean up durable subscription unsubscribe handling to simplify and resolve issues

["Robbie Gemmell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335174#comment-14335174 ] 

Robbie Gemmell commented on AMQ-5597:
-------------------------------------

The client was updated to resolve the mentioned NPE via QPID-6411. Will be requested for inclusion in 0.32 (which already branched for release prep).

> AMQP: clean up durable subscription unsubscribe handling to simplify and resolve issues
> ---------------------------------------------------------------------------------------
>
>                 Key: AMQ-5597
>                 URL: https://issues.apache.org/jira/browse/AMQ-5597
>             Project: ActiveMQ
>          Issue Type: Sub-task
>          Components: AMQP
>    Affects Versions: 5.11.0, 5.11.1
>            Reporter: Robbie Gemmell
>             Fix For: 5.12.0
>
>         Attachments: AMQ-5597.patch
>
>
> The current unsubscribe processing is identifying a 'null-source lookup' attach as indication to immediately unsubscribe a durable subscription, performing some trickery with capabilities. There are actually many other reasons reasons a client might do this type of attach, which might lead to prematurely ending a subscription. Fully closing (rather than a non-closing detach) the durable subscription link is to be the signal ending the subscription. The related code should be fixed to resolve this, and generally cleaned up to simplify things.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)