You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stephen Colebourne <sc...@btopenworld.com> on 2003/12/29 02:50:50 UTC

[collections] Version 3.0 - The final stretch

OK, my personal list of coding changes is complete. Its time for bug fixing,
javadoc fixing and releasing. (yes I know its taken a while and I'm a bad
release manager....)

I am planning on releasing a snapshot tomorrow to maven. Once that is up,
the primitives and observable code will be deleted. Then a beta release of
some kind seems appropriate.

Anyone who wants to start reviewing [collections] can start now!

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] Version 3.0 - The final stretch

Posted by Henri Yandell <ba...@generationjava.com>.

On Sat, 3 Jan 2004, Stephen Colebourne wrote:

> I am planning on deleting the deprecated for 3.0 code on Sunday, unless
> someone objects.

Looking forward to it. I've made the bad mistake of losing touch with
commons-collections development and am hoping that removal of the
deprecated stuff will give me less to get my head around.

All the decorator stuff looks great.

Hen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] Version 3.0 - The final stretch

Posted by Stephen Colebourne <sc...@btopenworld.com>.
Thanks ;-)
Stephen
From: <di...@multitask.com.au>
> I'm deploying them now....
> "Stephen Colebourne" <sc...@btopenworld.com> wrote on 03/01/2004 
> 11:20:26 AM:
> 
> > A snapshot has been tagged and created - 
> http://www.apache.org/~scolebourne
> > I have requested a Maven upload (I hope, JIRA seemed rather 
> unresponsive).



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] Version 3.0 - The final stretch

Posted by di...@multitask.com.au.
I'm deploying them now....
--
dIon Gillard, Multitask Consulting
Blog:      http://blogs.codehaus.org/people/dion/



"Stephen Colebourne" <sc...@btopenworld.com> wrote on 03/01/2004 
11:20:26 AM:

> A snapshot has been tagged and created - 
http://www.apache.org/~scolebourne
> I have requested a Maven upload (I hope, JIRA seemed rather 
unresponsive).
> There are lots of upload requests waiting though.
> 
> I am planning on deleting the deprecated for 3.0 code on Sunday, unless
> someone objects.
> 
> Stephen
> 
> 
> From: "Stephen Colebourne" <sc...@btopenworld.com>
> > I am planning on releasing a snapshot tomorrow to maven. Once that is 
up,
> > the primitives and observable code will be deleted. Then a beta 
release of
> > some kind seems appropriate.
> >
> > Anyone who wants to start reviewing [collections] can start now!
> >
> > Stephen
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] Version 3.0 - The final stretch

Posted by Stephen Colebourne <sc...@btopenworld.com>.
A snapshot has been tagged and created - http://www.apache.org/~scolebourne
I have requested a Maven upload (I hope, JIRA seemed rather unresponsive).
There are lots of upload requests waiting though.

I am planning on deleting the deprecated for 3.0 code on Sunday, unless
someone objects.

Stephen


From: "Stephen Colebourne" <sc...@btopenworld.com>
> I am planning on releasing a snapshot tomorrow to maven. Once that is up,
> the primitives and observable code will be deleted. Then a beta release of
> some kind seems appropriate.
>
> Anyone who wants to start reviewing [collections] can start now!
>
> Stephen



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] AbstractTestBidiMap issue

Posted by Stephen Colebourne <sc...@btopenworld.com>.
This test should fail, as the interface specifies that the result is the
same.

See the TestAbstractOrderedBidiMapDecorator class (of yours ;-) I just
checked in amended. Note the special handling for inverse.

Stephen

----- Original Message -----
From: "Michael Heuer" <he...@acm.org>
> In a situation where I have an unit test that extends AbstractTestBidiMap
> for a class that extends AbstractBidiMapDecorator,
>
> Testcase: testBidiInverse took 0.01 sec
> FAILED
> Inverse of inverse is not equal to original. expected same:<{key1=value1,
> key3=value3, key2=value2}> was not:<{key1=value1, key3=value3,
> key2=value2}>
> junit.framework.AssertionFailedError: Inverse of inverse is not equal to
> original. expected same:<{key1=value1, key3=value3, key2=value2}> was
> not:<{key1=value1, key3=value3, key2=value2}>
> ...
>
>
> This seems a bit odd, assertSame seems to not do the right thing here.
>
>    michael
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[collections] AbstractTestBidiMap issue

Posted by Michael Heuer <he...@acm.org>.
In a situation where I have an unit test that extends AbstractTestBidiMap
for a class that extends AbstractBidiMapDecorator,

Testcase: testBidiInverse took 0.01 sec
	FAILED
Inverse of inverse is not equal to original. expected same:<{key1=value1,
key3=value3, key2=value2}> was not:<{key1=value1, key3=value3,
key2=value2}>
junit.framework.AssertionFailedError: Inverse of inverse is not equal to
original. expected same:<{key1=value1, key3=value3, key2=value2}> was
not:<{key1=value1, key3=value3, key2=value2}>
...


This seems a bit odd, assertSame seems to not do the right thing here.

   michael


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] [proposal] Bag interface change

Posted by Michael Heuer <he...@acm.org>.
On Mon, 29 Dec 2003, Michael Heuer wrote:

> Stephen Colebourne wrote:
>
> > I am proposing to change the Bag interface.
> > http://jakarta.apache.org/commons/collections/api/org/apache/commons/collections/Bag.html
> >
> > Add:
> > equals(Object) - Two Bags are equal if they contain the same number of
> > occurrences of all the same elements.
> > hashCode() - The hashCode is defined as the sum total of each elements
> > hashcode, where the hashcode for an element is defined as (e==null   ? 0 :
> > e.hashCode()) ^ noOccurances)
> >
> > This will enable Bags to be compared.
>
> I'm seeing a problem related to this change with an unit test for a class
> that extends AbstractBagDecorator, but this failure doesn't show up in the
> [collections] unit tests.

Never mind, my [collections] snapshot jar file was out of date in my local
repository.

   michael


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] [proposal] Bag interface change

Posted by Michael Heuer <he...@acm.org>.
Stephen Colebourne wrote:

> I am proposing to change the Bag interface.
> http://jakarta.apache.org/commons/collections/api/org/apache/commons/collections/Bag.html
>
> Add:
> equals(Object) - Two Bags are equal if they contain the same number of
> occurrences of all the same elements.
> hashCode() - The hashCode is defined as the sum total of each elements
> hashcode, where the hashcode for an element is defined as (e==null   ? 0 :
> e.hashCode()) ^ noOccurances)
>
> This will enable Bags to be compared.

I'm seeing a problem related to this change with an unit test for a class
that extends AbstractBagDecorator, but this failure doesn't show up in the
[collections] unit tests.

Will investigate further.

   michael


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] Version 3.0 - The final stretch

Posted by Stephen Colebourne <sc...@btopenworld.com>.
From: "Michael Heuer" <he...@acm.org>
>  -  maven jar builds c-c-testframework-n.m.jar but maven
> jar:install-snapshot does not.
It should build it, but not install it. If it doesn't its a maven oddity.

>  -  maven build doesn't create javadocs for test framework
I'll take a look

>  -  AbstractTestBuffer is missing
There is no such class ;-)

>  -  Exception messages in AbstractTestMap (e.g. lines 396-405) refer to
> methods isNullXxxSupported which do not exist -- should be isAllowNullXxx
Done

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] Version 3.0 - The final stretch

Posted by Michael Heuer <he...@acm.org>.
A few things with the test framework,

 -  maven jar builds c-c-testframework-n.m.jar but maven
jar:install-snapshot does not.

 -  maven build doesn't create javadocs for test framework

 -  AbstractTestBuffer is missing

 -  Exception messages in AbstractTestMap (e.g. lines 396-405) refer to
methods isNullXxxSupported which do not exist -- should be isAllowNullXxx


I'm not enough of a maven guru yet to tackle the first two, but I can
create a patch for the latter ones if desired.

   michael


On Mon, 29 Dec 2003, Stephen Colebourne wrote:

> OK, my personal list of coding changes is complete. Its time for bug fixing,
> javadoc fixing and releasing. (yes I know its taken a while and I'm a bad
> release manager....)
>
> I am planning on releasing a snapshot tomorrow to maven. Once that is up,
> the primitives and observable code will be deleted. Then a beta release of
> some kind seems appropriate.
>
> Anyone who wants to start reviewing [collections] can start now!
>
> Stephen
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org