You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/08/25 16:20:16 UTC
[kudu-CR](branch-1.17.x) Unify patch file names to avoid RAT issue
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20424
to review the following change.
Change subject: Unify patch file names to avoid RAT issue
......................................................................
Unify patch file names to avoid RAT issue
Patch files should be named as *.patch to be excluded
correctly when run Apache RAT tool.
The exclude rule is descripted as thirdparty/patches/*.patch
in build-support/release/rat_exclude_files.txt.
Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Reviewed-on: http://gerrit.cloudera.org:8080/20423
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 092a0ef03b662d4d744eb3557f707cf9f0aba088)
---
M thirdparty/download-thirdparty.sh
R thirdparty/patches/llvm-ignore-flto-values.patch
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/20424/1
--
To view, visit http://gerrit.cloudera.org:8080/20424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Gerrit-Change-Number: 20424
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) Unify patch file names to avoid RAT issue
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20424 )
Change subject: Unify patch file names to avoid RAT issue
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Gerrit-Change-Number: 20424
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 26 Aug 2023 00:11:27 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Unify patch file names to avoid RAT issue
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20424 )
Change subject: Unify patch file names to avoid RAT issue
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Gerrit-Change-Number: 20424
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 25 Aug 2023 17:01:11 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Unify patch file names to avoid RAT issue
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: Unify patch file names to avoid RAT issue
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Gerrit-Change-Number: 20424
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) Unify patch file names to avoid RAT issue
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20424 )
Change subject: Unify patch file names to avoid RAT issue
......................................................................
Unify patch file names to avoid RAT issue
Patch files should be named as *.patch to be excluded
correctly when run Apache RAT tool.
The exclude rule is descripted as thirdparty/patches/*.patch
in build-support/release/rat_exclude_files.txt.
Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Reviewed-on: http://gerrit.cloudera.org:8080/20423
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 092a0ef03b662d4d744eb3557f707cf9f0aba088)
Reviewed-on: http://gerrit.cloudera.org:8080/20424
Tested-by: Yingchun Lai <la...@apache.org>
---
M thirdparty/download-thirdparty.sh
R thirdparty/patches/llvm-ignore-flto-values.patch
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Yingchun Lai: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I39449abcdbdaa698069395ab63b34495968dd1c4
Gerrit-Change-Number: 20424
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>