You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/06/03 14:05:59 UTC

[GitHub] [skywalking] peng-yongsheng opened a new pull request #2813: Remove storage annotation.

peng-yongsheng opened a new pull request #2813: Remove storage annotation.
URL: https://github.com/apache/skywalking/pull/2813
 
 
   Storage annotation has three attributes, `builder`, `deleteHistory`, `capableOfTimeSeries`. But `deleteHistory` and `capableOfTimeSeries` are associated with each other. The model is needed to delete history, then it has the performance problem of the delete operation, so, it needs to create as a  time series model. 
   Therefore, we are not necessarily setting it in entity definition. Put those two attributes setting in the processor is a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services