[GitHub] [spark] MaxGekk commented on a diff in pull request #39875: [SPARK-42305][SQL] Integrate `_LEGACY_ERROR_TEMP_1229` into `DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION`

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #39875:
URL: https://github.com/apache/spark/pull/39875#discussion_r1096570531


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala:
##########
@@ -804,14 +804,11 @@ class ExpressionParserSuite extends AnalysisTest {
       Literal(BigDecimal("90912830918230182310293801923652346786").underlying()))
     assertEqual("123.0E-28BD", Literal(BigDecimal("123.0E-28").underlying()))
     assertEqual("123.08BD", Literal(BigDecimal("123.08").underlying()))
+    val e = intercept[SparkArithmeticException](defaultParser.parseExpression("1.20E-38BD"))
     checkError(
-      exception = parseException("1.20E-38BD"),
-      errorClass = "_LEGACY_ERROR_TEMP_0061",

Review Comment:
   Sorry, I didn't get. The PR title and description are telling only about one error class `LEGACY_ERROR_TEMP_1229` but your PR affects another one. Could you elaborate this and revert unrelated changes, or make PR's title/description consistent with PR's changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org