You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/26 12:56:51 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #4358: Do not log error if page index can not be evaluated

alamb commented on PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1328041650

   > @alamb this change to good to me! But i still have a question about when to use error! in datafusion 🤔? 
   
   I like the "I generally subscribe to the following convention:" answer from this;
   https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels
   
   So only log errors when there is something a system adminstrator should look at / look into. If they can't do anything about it it probably shouldn't be an error (more like a warn! if it means a DataFusion bug or debug if more like an FYI)
   
   > after https://github.com/apache/arrow-datafusion/commit/d7a7fb61afe9ce2824aae737f65aec12d9513f7f merged i think there should no error log in test.
   
   Awesome!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org