You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhuangchong (via GitHub)" <gi...@apache.org> on 2023/03/24 01:07:54 UTC

[GitHub] [incubator-paimon] zhuangchong opened a new pull request, #704: [core] Improve the exception information when the changelog producer is `lookup` , the table has no primary key

zhuangchong opened a new pull request, #704:
URL: https://github.com/apache/incubator-paimon/pull/704

   *(Please specify the module before the PR name: [core] ... or [flink] ...)*
   
   ### Purpose
   
   *(What is the purpose of the change, or the associated issue)*
   
   Q1:
   when the changelog producer is `lookup` , the table has no primary key, The exception information is: `Changelog table with full-compaction must have primary keys`
   
   Improve:
   
   `Changelog table with lookup must have primary keys`
   
   
   Q2:
   When the system field ["_VALUE_COUNT", "_SEQUENCE_NUMBER", "_VALUE_KIND"] is included in the schema, the exception information is: `Field name["_VALUE_COUNT"] in schema cannot be exist in [["_VALUE_COUNT", "_SEQUENCE_NUMBER", "_VALUE_KIND"]]`
   
   Improve:
   `Field name["_VALUE_COUNT"] in schema cannot be exist in ["_VALUE_COUNT", "_SEQUENCE_NUMBER", "_VALUE_KIND"]`
   
   
   ### Tests
   
   *(List UT and IT cases to verify this change)*
   
   ### API and Format 
   
   *(Does this change affect API or storage format)*
   
   ### Documentation
   
   *(Does this change introduce a new feature)*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] zhuangchong commented on a diff in pull request #704: [core] Improve the exception information when the changelog producer is `lookup` , the table has no primary key

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on code in PR #704:
URL: https://github.com/apache/incubator-paimon/pull/704#discussion_r1148720200


##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -107,7 +109,7 @@ public static void validateTableSchema(TableSchema schema) {
                             checkState(
                                     !SYSTEM_FIELD_NAMES.contains(f),
                                     String.format(
-                                            "Field name[%s] in schema cannot be exist in [%s]",
+                                            "Field name[%s] in schema cannot be exist in %s",

Review Comment:
   I just modified the printed exception information, 
   before modification: `Field name["_VALUE_COUNT"] in schema cannot be exist in [["_VALUE_COUNT", "_SEQUENCE_NUMBER", "_VALUE_KIND"]]` ,
    after modification: `Field name["_VALUE_COUNT"] in schema cannot be exist in ["_VALUE_COUNT", "_SEQUENCE_NUMBER", "_VALUE_KIND"]`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] SteNicholas commented on a diff in pull request #704: [core] Improve the exception information when the changelog producer is `lookup` , the table has no primary key

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #704:
URL: https://github.com/apache/incubator-paimon/pull/704#discussion_r1148715363


##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -107,7 +109,7 @@ public static void validateTableSchema(TableSchema schema) {
                             checkState(
                                     !SYSTEM_FIELD_NAMES.contains(f),
                                     String.format(
-                                            "Field name[%s] in schema cannot be exist in [%s]",
+                                            "Field name[%s] in schema cannot be exist in %s",

Review Comment:
   Why need to change the info of `SYSTEM_FIELD_NAMES`? IMO, it's no need to change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] SteNicholas merged pull request #704: [core] Improve the exception information when the changelog producer is `lookup` , the table has no primary key

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #704:
URL: https://github.com/apache/incubator-paimon/pull/704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org