You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/03/11 23:09:03 UTC
Review Request 31953: DRILL-2128: Pt. 1: Preparatory changes before
core changes for actual fix.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31953/
-----------------------------------------------------------
Review request for drill and Parth Jagirdar.
Summary (updated)
-----------------
DRILL-2128: Pt. 1: Preparatory changes before core changes for actual fix.
Repository: drill-git
Description (updated)
-------
Added comments showing getColumns() column number and missing/misnamed columns.
Aligned SQL (Java strings and net SQL).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 0ea8d5c
Diff: https://reviews.apache.org/r/31953/diff/
Testing (updated)
-------
Ran tests.
Thanks,
Daniel Barclay
Re: Review Request 31953: DRILL-2128: Pt. 1: Preparatory changes
before core changes for actual fix.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31953/#review76204
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On March 11, 2015, 10:09 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31953/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 10:09 p.m.)
>
>
> Review request for drill and Parth Jagirdar.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added comments showing getColumns() column number and missing/misnamed columns.
> Aligned SQL (Java strings and net SQL).
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 0ea8d5c
>
> Diff: https://reviews.apache.org/r/31953/diff/
>
>
> Testing
> -------
>
> Ran tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>